Custom network + IPFS support #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 14, 2021 10:52
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
| return { image: object[image], name: object.name }; | ||
| try { | ||
| const object = await handleFetch(tokenURI); | ||
| // TODO: Check image_url existence. This is not part of EIP721 nor EIP1155 |
There was a problem hiding this comment.
What does this Todo mean? image_url is not part of any metadata standards?
There was a problem hiding this comment.
Right. This is custom made to support a specific platform (OpenSea) schema property.
There was a problem hiding this comment.
[nit] won't block on it but maybe we should add that context in the comment
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 28, 2021
adonesky1
reviewed
Oct 29, 2021
src/assets/CollectiblesController.ts
Outdated
| @@ -270,38 +347,33 @@ export class CollectiblesController extends BaseController< | |||
| * @param tokenId - The collectible identifier. | |||
| * @returns Promise resolving to the current collectible name and image. | |||
| */ | |||
| private async getCollectibleInformation( | |||
| async getCollectibleInformation( | |||
There was a problem hiding this comment.
Is this no longer private because it it will be accessed directly in mobile?
There was a problem hiding this comment.
No, I don't recall changing this, maybe it was by accident
adonesky1
previously approved these changes
Oct 29, 2021
adonesky1
approved these changes
Oct 29, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Add support for custom networks and IPFS urls
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Add support for custom networks and IPFS urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for custom networks by querying the blockchain as default and add support for IPFS metadata URIs
Tasks
BREAKING: ERC1155 support #615