add validation that the nft standard matches the type argument (#1455)

MetaMask · Oct 11, 2023 · 2fc8ba0 · 2fc8ba0
1 parent 62d12a4
commit 2fc8ba0
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/packages/assets-controllers/src/NftController.ts b/packages/assets-controllers/src/NftController.ts
@@ -1073,6 +1073,12 @@ export class NftController extends BaseController<NftConfig, NftState> {
       asset.tokenId,
     );
 
+    if (nftMetadata.standard && nftMetadata.standard !== type) {
+      throw rpcErrors.invalidInput(
+        `Suggested NFT of type ${nftMetadata.standard} does not match received type ${type}`,
+      );
+    }
+
     const suggestedNftMeta: SuggestedNftMeta = {
       asset: { ...asset, ...nftMetadata },
       type,