add validation that the nft standard matches the type argument #1455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/854
Currently when
wallet_watchAsset
is called with typeERC721
orERC1155
, we don't check whether the asset actually matches the type passed - we push it into a flow for suggested NFTs do a bunch of other validation, and if it passes we add it with the correct value forstandard
even if it doesn't match thetype
(standard) originally passed in the request. This adds validation of this type.After:
https://github.com/MetaMask/core/assets/34557516/92a9bba5-c466-4ebc-b82c-b395649be52b
Changelog
@metamask/assets-controllers
watchNFT
method matches thetype
argument passed with the request.Checklist