BREAKING: Bump to Node 16 (#1262)

* Bump to Node 16 * devDeps: @types/node@14.14.31->16.18.24 * docs: update nodejs version in contributing.md * Fix lint * Update docs/contributing.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Update docs/contributing.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MetaMask · Oct 11, 2023 · f8380e1 · f8380e1
1 parent f7c8774
commit f8380e1
Show file tree

Hide file tree

Showing 24 changed files with 40 additions and 39 deletions.
diff --git a/.github/workflows/lint-build-test.yml b/.github/workflows/lint-build-test.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [16.x, 18.x, 20.x]
     outputs:
       child-workspace-package-names: ${{ steps.workspace-package-names.outputs.child-workspace-package-names }}
     steps:
@@ -32,7 +32,7 @@ jobs:
     needs: prepare
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [16.x, 18.x, 20.x]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
@@ -56,7 +56,7 @@ jobs:
     needs: prepare
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [16.x, 18.x, 20.x]
         package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
     steps:
       - uses: actions/checkout@v3
@@ -81,7 +81,7 @@ jobs:
     needs: prepare
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [16.x, 18.x, 20.x]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
@@ -105,7 +105,7 @@ jobs:
     needs: prepare
     strategy:
       matrix:
-        node-version: [14.x, 16.x]
+        node-version: [16.x, 18.x, 20.x]
         package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
     steps:
       - uses: actions/checkout@v3

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v14
+v16
diff --git a/constraints.pro b/constraints.pro
@@ -276,8 +276,8 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, null, DependencyType) :-
   workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, DependencyType),
   DependencyType == 'devDependencies'.
 
-% All packages must specify a minimum Node version of 14.
-gen_enforced_field(WorkspaceCwd, 'engines.node', '>=14.0.0').
+% All packages must specify a minimum Node version of 16.
+gen_enforced_field(WorkspaceCwd, 'engines.node', '>=16.0.0').
 
 % All published packages are public.
 gen_enforced_field(WorkspaceCwd, 'publishConfig.access', 'public') :-

diff --git a/docs/contributing.md b/docs/contributing.md
@@ -2,7 +2,7 @@
 
 ## Getting started
 
-- Install [Node.js](https://nodejs.org) version 14.
+- Install [Node.js](https://nodejs.org) version 16.
   - If you're using [NVM](https://github.com/creationix/nvm#installation) (recommended), `nvm use` will ensure that the right version is installed.
 - Install [Yarn v3](https://yarnpkg.com/getting-started/install).
 - Run `yarn install` to install dependencies and run any required post-install scripts.
@@ -14,7 +14,8 @@
 - Run `yarn workspace <workspaceName> run jest --no-coverage <file>` to run a test file within the context of a package.
 - Run `yarn test` to run tests for all packages.
 
-> **Note**  
+> **Note**
+>
 > `workspaceName` in these commands is the `name` field within a package's `package.json`, e.g., `@metamask/address-book-controller`, not the directory where it is located, e.g., `packages/address-book-controller`.
 
 ## Using packages in other projects during development/testing

diff --git a/package.json b/package.json
@@ -39,7 +39,7 @@
     "@metamask/eslint-config-jest": "^9.0.0",
     "@metamask/eslint-config-nodejs": "^9.0.0",
     "@metamask/eslint-config-typescript": "^9.0.1",
-    "@types/node": "^14.14.31",
+    "@types/node": "^16.18.24",
     "@typescript-eslint/eslint-plugin": "^4.33.0",
     "@typescript-eslint/parser": "^4.33.0",
     "eslint": "^7.24.0",
@@ -63,7 +63,7 @@
   },
   "packageManager": "yarn@3.3.0",
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "lavamoat": {
     "allowScripts": {

diff --git a/packages/address-book-controller/package.json b/packages/address-book-controller/package.json
@@ -43,7 +43,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/announcement-controller/package.json b/packages/announcement-controller/package.json
@@ -43,7 +43,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/approval-controller/package.json b/packages/approval-controller/package.json
@@ -47,7 +47,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/assets-controllers/package.json b/packages/assets-controllers/package.json
@@ -56,7 +56,7 @@
   "devDependencies": {
     "@metamask/auto-changelog": "^3.1.0",
     "@types/jest": "^27.4.1",
-    "@types/node": "^14.14.31",
+    "@types/node": "^16.18.24",
     "deepmerge": "^4.2.2",
     "ethjs-provider-http": "^0.1.6",
     "jest": "^27.5.1",
@@ -73,7 +73,7 @@
     "@metamask/network-controller": "workspace:^"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/base-controller/package.json b/packages/base-controller/package.json
@@ -45,7 +45,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/composable-controller/package.json b/packages/composable-controller/package.json
@@ -44,7 +44,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/controller-utils/package.json b/packages/controller-utils/package.json
@@ -50,7 +50,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/ens-controller/package.json b/packages/ens-controller/package.json
@@ -47,7 +47,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/gas-fee-controller/package.json b/packages/gas-fee-controller/package.json
@@ -58,7 +58,7 @@
     "@metamask/network-controller": "workspace:^"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/keyring-controller/package.json b/packages/keyring-controller/package.json
@@ -56,7 +56,7 @@
     "uuid": "^8.3.2"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/message-manager/package.json b/packages/message-manager/package.json
@@ -48,7 +48,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/network-controller/package.json b/packages/network-controller/package.json
@@ -58,7 +58,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/notification-controller/package.json b/packages/notification-controller/package.json
@@ -45,7 +45,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/permission-controller/package.json b/packages/permission-controller/package.json
@@ -54,7 +54,7 @@
     "@metamask/approval-controller": "workspace:^"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/phishing-controller/package.json b/packages/phishing-controller/package.json
@@ -48,7 +48,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/preferences-controller/package.json b/packages/preferences-controller/package.json
@@ -43,7 +43,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/rate-limit-controller/package.json b/packages/rate-limit-controller/package.json
@@ -44,7 +44,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/packages/transaction-controller/package.json b/packages/transaction-controller/package.json
@@ -46,7 +46,7 @@
   "devDependencies": {
     "@metamask/auto-changelog": "^3.1.0",
     "@types/jest": "^27.4.1",
-    "@types/node": "^14.14.31",
+    "@types/node": "^16.18.24",
     "deepmerge": "^4.2.2",
     "ethjs-provider-http": "^0.1.6",
     "jest": "^27.5.1",
@@ -57,7 +57,7 @@
     "typescript": "~4.6.3"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=16.0.0"
   },
   "publishConfig": {
     "access": "public",

diff --git a/yarn.lock b/yarn.lock
@@ -1355,7 +1355,7 @@ __metadata:
     "@metamask/preferences-controller": "workspace:^"
     "@metamask/utils": ^5.0.2
     "@types/jest": ^27.4.1
-    "@types/node": ^14.14.31
+    "@types/node": ^16.18.24
     "@types/uuid": ^8.3.0
     abort-controller: ^3.0.0
     async-mutex: ^0.2.6
@@ -1482,7 +1482,7 @@ __metadata:
     "@metamask/eslint-config-jest": ^9.0.0
     "@metamask/eslint-config-nodejs": ^9.0.0
     "@metamask/eslint-config-typescript": ^9.0.1
-    "@types/node": ^14.14.31
+    "@types/node": ^16.18.24
     "@typescript-eslint/eslint-plugin": ^4.33.0
     "@typescript-eslint/parser": ^4.33.0
     eslint: ^7.24.0
@@ -1917,7 +1917,7 @@ __metadata:
     "@metamask/controller-utils": "workspace:^"
     "@metamask/network-controller": "workspace:^"
     "@types/jest": ^27.4.1
-    "@types/node": ^14.14.31
+    "@types/node": ^16.18.24
     async-mutex: ^0.2.6
     babel-runtime: ^6.26.0
     deepmerge: ^4.2.2
@@ -2414,10 +2414,10 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@types/node@npm:*, @types/node@npm:^14.14.31":
-  version: 14.14.31
-  resolution: "@types/node@npm:14.14.31"
-  checksum: 5b9ab3660ee63abc57affc836c0d50b2941a862c5b6c241c02762d8e1ad610f6b0d350d7426218dc401b5abc7d6294ee1b475da7c331e486d59a5608d1a0b777
+"@types/node@npm:*, @types/node@npm:^16.18.24":
+  version: 16.18.24
+  resolution: "@types/node@npm:16.18.24"
+  checksum: 0b221b7f56f3c4911e90dfcc217db3866eb13b7af9390b8f668377f1211b2b3ca808e0128a29d0cef8aa0944523852531e827b923b35e5fa9063db87af7b41a0
   languageName: node
   linkType: hard