-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Bump to Node 16 #1262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
ty for the updates! I swear I looked for docs that mentioned Node 14 but didn't find any 😅 |
...However, should we make sure each package has a non-major release published before merging this @FrederikBolding ? Considering this repo does not have as straightforward a flow for backports, we might as well get any pending non-breaking changes published first. WDYT? |
Both the extension and mobile are to my knowledge ready for Node 16. So not sure if there is a reason to wait? 🤔 As in, why would be doing backports anyway? |
I don't have a scenario in mind - I just view is as standard practice and you never know when The Unknown Unknown rears a head (and version rollbacks wouldn't be unheard of I think). And in the off-chance we have external dependents of these packages with different runtime constraints, this may make a big change for such users. |
Fair enough, I am merely trying to unblock #1184 and thought it was easier to do a release after all had been merged. But I'm also fine with us publishing a release first. Doesn't look like many packages have outstanding changes though |
docs/contributing.md
Outdated
@@ -14,8 +14,7 @@ | |||
- Run `yarn workspace <workspaceName> run jest --no-coverage <file>` to run a test file within the context of a package. | |||
- Run `yarn test` to run tests for all packages. | |||
|
|||
> **Note** | |||
> `workspaceName` in these commands is the `name` field within a package's `package.json`, e.g., `@metamask/address-book-controller`, not the directory where it is located, e.g., `packages/address-book-controller`. | |||
> **Note** > `workspaceName` in these commands is the `name` field within a package's `package.json`, e.g., `@metamask/address-book-controller`, not the directory where it is located, e.g., `packages/address-book-controller`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Seems that a newline was accidentally removed here
> **Note** > `workspaceName` in these commands is the `name` field within a package's `package.json`, e.g., `@metamask/address-book-controller`, not the directory where it is located, e.g., `packages/address-book-controller`. | |
> **Note** | |
> `workspaceName` in these commands is the `name` field within a package's `package.json`, e.g., `@metamask/address-book-controller`, not the directory where it is located, e.g., `packages/address-book-controller`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint is drunk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not sure what is going on here. This is what Prettier wants
I have applied the |
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
This should be good to review now! |
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: @types/node@14.18.43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like we need to run |
@Gudahtt That is what resulted in the contributing.md change that you requested reverted 😅 |
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been built into Node.js since v15.4.0, and is included in all versions of v16. It is also supported by all browsers that our extension supports, and has been supported by React Native since v0.60.0. This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package.
The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been built into Node.js since v15.4.0, and is included in all versions of v16. It is also supported by all browsers that our extension supports, and has been supported by React Native since v0.60.0. This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package.
The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been built into Node.js since v15.4.0, and is included in all versions of v16. It is also supported by all browsers that our extension supports, and has been supported by React Native since v0.60.0. This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package.
The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been built into Node.js since v15.4.0, and is included in all versions of v16. It is also supported by all browsers that our extension supports, and has been supported by React Native since v0.60.0. This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package.
The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been built into Node.js since v15.4.0, and is included in all versions of v16. It is also supported by all browsers that our extension supports, and has been supported by React Native since v0.60.0. This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package.
## Explanation The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been [built into Node.js since v15.4.0](https://nodejs.org/docs/latest-v16.x/api/globals.html#class-abortcontroller), and is included in all versions of v16. It is also supported by [all browsers that our extension supports](https://developer.mozilla.org/en-US/docs/Web/API/AbortController#browser_compatibility), and has been [supported by React Native since v0.60.0](https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#v0600). This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package. ## References None ## Changelog ### `@metamask/assets-controllers` ### Removed - **BREAKING:** Remove AbortController polyfill - This package now assumes that the AbortController global exists ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
* Bump to Node 16 * devDeps: @types/node@14.14.31->16.18.24 * docs: update nodejs version in contributing.md * Fix lint * Update docs/contributing.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Update docs/contributing.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
## Explanation The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been [built into Node.js since v15.4.0](https://nodejs.org/docs/latest-v16.x/api/globals.html#class-abortcontroller), and is included in all versions of v16. It is also supported by [all browsers that our extension supports](https://developer.mozilla.org/en-US/docs/Web/API/AbortController#browser_compatibility), and has been [supported by React Native since v0.60.0](https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#v0600). This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package. ## References None ## Changelog ### `@metamask/assets-controllers` ### Removed - **BREAKING:** Remove AbortController polyfill - This package now assumes that the AbortController global exists ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
* Bump to Node 16 * devDeps: @types/node@14.14.31->16.18.24 * docs: update nodejs version in contributing.md * Fix lint * Update docs/contributing.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Update docs/contributing.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> --------- Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
## Explanation The `AbortController` polyfill has not been required since updating to a minimum Node.js version of v16 in #1262. This API has been [built into Node.js since v15.4.0](https://nodejs.org/docs/latest-v16.x/api/globals.html#class-abortcontroller), and is included in all versions of v16. It is also supported by [all browsers that our extension supports](https://developer.mozilla.org/en-US/docs/Web/API/AbortController#browser_compatibility), and has been [supported by React Native since v0.60.0](https://github.com/react-native-community/releases/blob/master/CHANGELOG.md#v0600). This helps unblock the TypeScript update to v4.8.4. The update resulted in some type errors from this polyfill package. ## References None ## Changelog ### `@metamask/assets-controllers` ### Removed - **BREAKING:** Remove AbortController polyfill - This package now assumes that the AbortController global exists ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Description
Bumps the minimum Node version of the packages to
16.18.24
.Changes
16.18.24