Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkController API normalization: rename properties state to networkDetails #1019

Closed
Gudahtt opened this issue Dec 13, 2022 · 1 comment · Fixed by #1074
Closed

NetworkController API normalization: rename properties state to networkDetails #1019

Gudahtt opened this issue Dec 13, 2022 · 1 comment · Fixed by #1074
Assignees
@cryptodev-2s
Labels
enhancement New feature or request team-wallet-api-platform

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Dec 13, 2022

We should rename the properties state to networkDetails, to more closely align with the extension network controller. Of the two, networkDetails was chosen because it's more descriptive of the state contents. This state is a collection of properties about the network that we have discovered at runtime (i.e. they are not configured or statically set).

This is part of a larger effort to normalize the API of both network controllers, to make them easier to merge.
@Gudahtt Gudahtt added the enhancement New feature or request label Dec 13, 2022
@Gudahtt Gudahtt mentioned this issue Dec 13, 2022
Closed
14 tasks
@cryptodev-2s cryptodev-2s self-assigned this Jan 16, 2023
cryptodev-2s added a commit that referenced this issue Jan 30, 2023
@cryptodev-2s
rename network controller properties state property (#1074)
5ed1bd3 
This PR renames properties network controller state property to
networkDetails.
Related issue
[#1019](https://app.zenhub.com/workspaces/core-621e46b4d7103800171d1b02/issues/gh/metamask/core/1019)
@mcmire mcmire linked a pull request Mar 16, 2023 that will close this issue
rename network controller properties state property #1074
Merged
@mcmire
Copy link
Contributor

mcmire commented Mar 21, 2023

This was closed in #1074.

@mcmire mcmire closed this as completed Mar 21, 2023
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@cryptodev-2s @MajorLift
rename network controller properties state property (#1074)
b680c18 
This PR renames properties network controller state property to
networkDetails.
Related issue
[#1019](https://app.zenhub.com/workspaces/core-621e46b4d7103800171d1b02/issues/gh/metamask/core/1019)
MajorLift pushed a commit that referenced this issue Oct 11, 2023
@cryptodev-2s @MajorLift
rename network controller properties state property (#1074)
a4af699 
This PR renames properties network controller state property to
networkDetails.
Related issue
[#1019](https://app.zenhub.com/workspaces/core-621e46b4d7103800171d1b02/issues/gh/metamask/core/1019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cryptodev-2s cryptodev-2s

Labels
enhancement New feature or request team-wallet-api-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename network controller properties state property MetaMask/core
4 participants
@mcmire @kenhkan @Gudahtt @cryptodev-2s