rename network controller properties state property #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Base automatically changed from
improve-network-controller-unit-tests
to
main
January 24, 2023 16:25
This comment was marked as resolved.
This comment was marked as resolved.
cryptodev-2s
force-pushed
the
rename-network-controller-properties-state
branch
from
ba0d6e6
to
e51c954
Compare
PR has been rebased onto main |
cryptodev-2s
force-pushed
the
rename-network-controller-properties-state
branch
from
e51c954
to
a2d88a7
Compare
Gudahtt
previously approved these changes
Jan 25, 2023
mcmire
previously approved these changes
Jan 26, 2023
cryptodev-2s
force-pushed
the
rename-network-controller-properties-state
branch
from
a2d88a7
to
e36e986
Compare
Gudahtt
approved these changes
Jan 30, 2023
|
@cryptodev-2s FYI if you use the "Update branch" button on GitHub, it will preserve any PR approvals. Rebasing manually requires re-approving. |
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This PR renames properties network controller state property to networkDetails. Related issue [#1019](https://app.zenhub.com/workspaces/core-621e46b4d7103800171d1b02/issues/gh/metamask/core/1019)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This PR renames properties network controller state property to networkDetails. Related issue [#1019](https://app.zenhub.com/workspaces/core-621e46b4d7103800171d1b02/issues/gh/metamask/core/1019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames properties network controller state property to networkDetails.
Related issue #1019