updated the previously owned state for nft #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
changed the title
3 tasks
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Fixes [17206](MetaMask/metamask-extension#17206) Ideally, when a user previously owned an NFT, and then received the same one back, we'd put that NFT back into its own group. With the current implementation, the NFT is always stuck in the Previously Owned category, even when imported again. This PR is to update the Nft Controllers to add the NFT back to its own group if we are re-importing it.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Fixes [17206](MetaMask/metamask-extension#17206) Ideally, when a user previously owned an NFT, and then received the same one back, we'd put that NFT back into its own group. With the current implementation, the NFT is always stuck in the Previously Owned category, even when imported again. This PR is to update the Nft Controllers to add the NFT back to its own group if we are re-importing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 17206
Ideally, when a user previously owned an NFT, and then received the same one back, we'd put that NFT back into its own group. With the current implementation, the NFT is always stuck in the Previously Owned category, even when imported again. This PR is to update the Nft Controllers to add the NFT back to its own group if we are re-importing it.