Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFTs: Importing a previously sent NFT still displays NFT in the "Previously Owned" group #17206

Closed
darkwing opened this issue Jan 13, 2023 · 0 comments · Fixed by MetaMask/core#1082
Closed

NFTs: Importing a previously sent NFT still displays NFT in the "Previously Owned" group #17206

darkwing opened this issue Jan 13, 2023 · 0 comments · Fixed by MetaMask/core#1082
Assignees
@NidhiKJha
Labels
area-NFTs team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug

Comments

@darkwing
Copy link
Contributor

Describe the bug

In an ideal world, if a user previously owned an NFT, and then received the same one back, we'd put that NFT back into its own group. With the current implementation, the NFT is always stuck in the Previously Owned category, even when imported again.

Steps to reproduce

  1. Import an NFT
  2. Send the NFT to a second address
  3. Send the NFT back to the original address
  4. See the NFT listed under "Previously owned"

Error messages or log output

No response

Version

10.23

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response
@darkwing darkwing added type-bug team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead area-NFTs labels Jan 13, 2023
@vthomas13 vthomas13 assigned vthomas13 and unassigned vthomas13 Jan 23, 2023
@NidhiKJha NidhiKJha self-assigned this Jan 23, 2023
@NidhiKJha NidhiKJha mentioned this issue Jan 27, 2023
Merged
NidhiKJha added a commit to MetaMask/core that referenced this issue Jan 27, 2023
@NidhiKJha
updated the previously owned state for nft (#1082)
0c91d25 
Fixes
[17206](MetaMask/metamask-extension#17206)

Ideally, when a user previously owned an NFT, and then received the same
one back, we'd put that NFT back into its own group. With the current
implementation, the NFT is always stuck in the Previously Owned
category, even when imported again. This PR is to update the Nft
Controllers to add the NFT back to its own group if we are re-importing
it.
MajorLift pushed a commit to MetaMask/core that referenced this issue Oct 11, 2023
@NidhiKJha @MajorLift
updated the previously owned state for nft (#1082)
b1f6048 
Fixes
[17206](MetaMask/metamask-extension#17206)

Ideally, when a user previously owned an NFT, and then received the same
one back, we'd put that NFT back into its own group. With the current
implementation, the NFT is always stuck in the Previously Owned
category, even when imported again. This PR is to update the Nft
Controllers to add the NFT back to its own group if we are re-importing
it.
MajorLift pushed a commit to MetaMask/core that referenced this issue Oct 11, 2023
@NidhiKJha @MajorLift
updated the previously owned state for nft (#1082)
e707a6d 
Fixes
[17206](MetaMask/metamask-extension#17206)

Ideally, when a user previously owned an NFT, and then received the same
one back, we'd put that NFT back into its own group. With the current
implementation, the NFT is always stuck in the Previously Owned
category, even when imported again. This PR is to update the Nft
Controllers to add the NFT back to its own group if we are re-importing
it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NidhiKJha NidhiKJha

Labels
area-NFTs team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated the previously owned state for nft MetaMask/core
3 participants
@darkwing @vthomas13 @NidhiKJha