Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to preview build documentation #1167

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Apr 5, 2023

A warning has been added to the preview build documentation about a
known problem with that workflow. The warning explains the workaround
for the problem.

Checklist

  • Tests are included if applicable
  • Any added code is fully documented

Issue

Relates to #1075

@Gudahtt Gudahtt force-pushed the add-preview-builds-warning branch from 39cd7e4 to e0d7558 Compare April 5, 2023 15:02
A warning has been added to the preview build documentation about a
known problem with that workflow. The warning explains the workaround
for the problem.
@Gudahtt Gudahtt force-pushed the add-preview-builds-warning branch from e0d7558 to 5d6c793 Compare April 5, 2023 15:04
@Gudahtt Gudahtt changed the title WIP Add warning to preview build documentation Apr 5, 2023
@Gudahtt Gudahtt marked this pull request as ready for review April 5, 2023 15:06
@Gudahtt Gudahtt requested a review from a team as a code owner April 5, 2023 15:06
Mrtenz
Mrtenz previously approved these changes Apr 5, 2023
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that's why I was "randomly" not able to install some preview packages anymore... 😅 I'm glad you figured it out. Will PR this to snaps-monorepo as well.

docs/contributing.md Outdated Show resolved Hide resolved
Gudahtt and others added 2 commits April 5, 2023 14:18
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunate and makes me think that we ought to figure out another way to accommodate installing preview builds. But this works for now.

@Gudahtt Gudahtt merged commit 4149062 into main Apr 5, 2023
@Gudahtt Gudahtt deleted the add-preview-builds-warning branch April 5, 2023 21:52
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Add warning to preview build documentation

A warning has been added to the preview build documentation about a
known problem with that workflow. The warning explains the workaround
for the problem.

* Fix grammar

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

---------

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* Add warning to preview build documentation

A warning has been added to the preview build documentation about a
known problem with that workflow. The warning explains the workaround
for the problem.

* Fix grammar

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

---------

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants