Add warning message for non-preview package installation when using preview builds #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1332 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 149 149
Lines 4549 4549
Branches 745 745
=======================================
Hits 4375 4375
Misses 174 174 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FrederikBolding
approved these changes
Apr 11, 2023
Mrtenz
force-pushed
the
mrtenz/preview-builds-warning
branch
from
9abeef4
to
25a51fc
Compare
Warn the potential problem when installing non-preview `@metamask/`-scoped packages while using preview builds. Users can solve this by removing the `.npmrc` / `.yarnrc.yml` changes to install the missing packages and restoring the preview build credentials afterward. For more detail, check [issue #1075](MetaMask/core#1075).
Changed "you can workaround the problem" to "you can work around the problem".
Mrtenz
force-pushed
the
mrtenz/preview-builds-warning
branch
from
25a51fc
to
bf08f3e
Compare
|
@Gudahtt says he hasn't found a way to fix the problem, but is it possible to make a yarn plugin to detect the failure state and show an error message pointing to the GitHub issue? |
GuillaumeRx
pushed a commit
that referenced
this pull request
Jun 22, 2023
…review builds (#1332) * Add warning for non-preview package installation in README Warn the potential problem when installing non-preview `@metamask/`-scoped packages while using preview builds. Users can solve this by removing the `.npmrc` / `.yarnrc.yml` changes to install the missing packages and restoring the preview build credentials afterward. For more detail, check [issue #1075](MetaMask/core#1075). * Fix typo in README.md Changed "you can workaround the problem" to "you can work around the problem". --------- Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a warning message in the README file to caution users against the potential problems they might face when installing non-preview
@metamask/-scoped packages while using preview builds.This is copied from
MetaMask/core, thanks to @Gudahtt.Changes