-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC721 & ERC1155 wallet_watchAsset
support
#1173
Conversation
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
8671b91
to
d912178
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
ff1fe78
to
1c4a59b
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
cacb82e
to
3cff8ed
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
2b5cc70
to
65f3bc7
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
0976576
to
74b511e
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
74b511e
to
5809559
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
5809559
to
16c7759
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
…er directly to manage suggestedAsset state
caf517b
to
a11a2de
Compare
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
* wallet_watchNFT spike
Controller side changes for V1 of MIP-1 (extend
wallet_watchAsset
to support ERC721 and ERC1155 tokens).I am actively tracking the changes to the ERC20Update: The refactor to match this pattern was done in this commit.wallet_watchAsset
flow (here & here) and will match that pattern when it has been merged.The end feature can be tested by running the this extension branch and this branch of the test dapp locally. The extension PR is using the latest preview builds from this PR.Preview builds are a bit broken now 😬 , but you can test using tarballs. Happy to help if you wish to do this!Demo:
https://github.com/MetaMask/core/assets/34557516/62824cd8-2725-438f-8dc1-1ec23af4f889