Modify error handling for wallet_WatchAsset in NftController #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
commented
Jun 1, 2023
| } catch { | ||
| errors.ownerFetchError = true; | ||
| } catch (error) { | ||
| throw rpcErrors.resourceUnavailable(`${error}`); |
There was a problem hiding this comment.
@Gudahtt @shanejonas I've put this unable to verify owner error as a resourceUnavailable code for now.
There was a problem hiding this comment.
should this be error.message?
There was a problem hiding this comment.
adonesky1
force-pushed
the
watchNFT_revert-error-handling-pattern
branch
from
2662aab
to
011613d
Compare
adonesky1
commented
Jun 1, 2023
Comment on lines
+1039
to
+1041
| throw rpcErrors.invalidInput( | ||
| 'Suggested NFT is not owned by the selected account', | ||
| ); |
There was a problem hiding this comment.
@Gudahtt @shanejonas I've put this error as a invalidInput code for now, since as Mark pointed out the dApp should not have sent a request for an asset the user does not own.
adonesky1
force-pushed
the
watchNFT_revert-error-handling-pattern
branch
from
011613d
to
d663be0
Compare
BelfordZ
previously approved these changes
Jun 2, 2023
bergarces
previously approved these changes
Jun 2, 2023
shanejonas
approved these changes
Jun 2, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Modify error handling for wallet_WatchAsset in NftController
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Modify error handling for wallet_WatchAsset in NftController
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the error handling pattern for the wallet_watchAsset NFT support introduced in #1173. In that approach we were passing certain errors in the
requestDatato theApprovalControllerso that the errors could be displayed in the UI. We have elected to not pursue this approach because it diverges from the pattern of throwing these errors directly to the dApp we use everywhere else.