Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Bump to Node 16 #1262

Merged
merged 8 commits into from
Apr 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/lint-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [16.x, 18.x, 20.x]
outputs:
child-workspace-package-names: ${{ steps.workspace-package-names.outputs.child-workspace-package-names }}
steps:
Expand All @@ -32,7 +32,7 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -56,7 +56,7 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [16.x, 18.x, 20.x]
package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
steps:
- uses: actions/checkout@v3
Expand All @@ -81,7 +81,7 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -105,7 +105,7 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [16.x, 18.x, 20.x]
package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14
v16
4 changes: 2 additions & 2 deletions constraints.pro
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,8 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, null, DependencyType) :-
workspace_has_dependency(WorkspaceCwd, DependencyIdent, DependencyRange, DependencyType),
DependencyType == 'devDependencies'.

% All packages must specify a minimum Node version of 14.
gen_enforced_field(WorkspaceCwd, 'engines.node', '>=14.0.0').
% All packages must specify a minimum Node version of 16.
gen_enforced_field(WorkspaceCwd, 'engines.node', '>=16.0.0').

% All published packages are public.
gen_enforced_field(WorkspaceCwd, 'publishConfig.access', 'public') :-
Expand Down
5 changes: 3 additions & 2 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Getting started

- Install [Node.js](https://nodejs.org) version 14.
- Install [Node.js](https://nodejs.org) version 16.
- If you're using [NVM](https://github.com/creationix/nvm#installation) (recommended), `nvm use` will ensure that the right version is installed.
- Install [Yarn v3](https://yarnpkg.com/getting-started/install).
- Run `yarn install` to install dependencies and run any required post-install scripts.
Expand All @@ -14,7 +14,8 @@
- Run `yarn workspace <workspaceName> run jest --no-coverage <file>` to run a test file within the context of a package.
- Run `yarn test` to run tests for all packages.

> **Note**
> **Note**
FrederikBolding marked this conversation as resolved.
Show resolved Hide resolved
>
> `workspaceName` in these commands is the `name` field within a package's `package.json`, e.g., `@metamask/address-book-controller`, not the directory where it is located, e.g., `packages/address-book-controller`.

## Using packages in other projects during development/testing
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@metamask/eslint-config-jest": "^9.0.0",
"@metamask/eslint-config-nodejs": "^9.0.0",
"@metamask/eslint-config-typescript": "^9.0.1",
"@types/node": "^14.14.31",
"@types/node": "^16.18.24",
"@typescript-eslint/eslint-plugin": "^4.33.0",
"@typescript-eslint/parser": "^4.33.0",
"eslint": "^7.24.0",
Expand All @@ -63,7 +63,7 @@
},
"packageManager": "yarn@3.3.0",
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"lavamoat": {
"allowScripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/address-book-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/announcement-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/approval-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
4 changes: 2 additions & 2 deletions packages/assets-controllers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"devDependencies": {
"@metamask/auto-changelog": "^3.1.0",
"@types/jest": "^27.4.1",
"@types/node": "^14.14.31",
"@types/node": "^16.18.24",
"deepmerge": "^4.2.2",
"ethjs-provider-http": "^0.1.6",
"jest": "^27.5.1",
Expand All @@ -73,7 +73,7 @@
"@metamask/network-controller": "workspace:^"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/base-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/composable-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/controller-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/ens-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/gas-fee-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"@metamask/network-controller": "workspace:^"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/keyring-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"uuid": "^8.3.2"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/message-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/network-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/notification-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/permission-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@metamask/approval-controller": "workspace:^"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/phishing-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/preferences-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
2 changes: 1 addition & 1 deletion packages/rate-limit-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
4 changes: 2 additions & 2 deletions packages/transaction-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"devDependencies": {
"@metamask/auto-changelog": "^3.1.0",
"@types/jest": "^27.4.1",
"@types/node": "^14.14.31",
"@types/node": "^16.18.24",
"deepmerge": "^4.2.2",
"ethjs-provider-http": "^0.1.6",
"jest": "^27.5.1",
Expand All @@ -57,7 +57,7 @@
"typescript": "~4.6.3"
},
"engines": {
"node": ">=14.0.0"
"node": ">=16.0.0"
},
"publishConfig": {
"access": "public",
Expand Down
14 changes: 7 additions & 7 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,7 @@ __metadata:
"@metamask/preferences-controller": "workspace:^"
"@metamask/utils": ^5.0.2
"@types/jest": ^27.4.1
"@types/node": ^14.14.31
"@types/node": ^16.18.24
"@types/uuid": ^8.3.0
abort-controller: ^3.0.0
async-mutex: ^0.2.6
Expand Down Expand Up @@ -1482,7 +1482,7 @@ __metadata:
"@metamask/eslint-config-jest": ^9.0.0
"@metamask/eslint-config-nodejs": ^9.0.0
"@metamask/eslint-config-typescript": ^9.0.1
"@types/node": ^14.14.31
"@types/node": ^16.18.24
"@typescript-eslint/eslint-plugin": ^4.33.0
"@typescript-eslint/parser": ^4.33.0
eslint: ^7.24.0
Expand Down Expand Up @@ -1917,7 +1917,7 @@ __metadata:
"@metamask/controller-utils": "workspace:^"
"@metamask/network-controller": "workspace:^"
"@types/jest": ^27.4.1
"@types/node": ^14.14.31
"@types/node": ^16.18.24
async-mutex: ^0.2.6
babel-runtime: ^6.26.0
deepmerge: ^4.2.2
Expand Down Expand Up @@ -2414,10 +2414,10 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:*, @types/node@npm:^14.14.31":
version: 14.14.31
resolution: "@types/node@npm:14.14.31"
checksum: 5b9ab3660ee63abc57affc836c0d50b2941a862c5b6c241c02762d8e1ad610f6b0d350d7426218dc401b5abc7d6294ee1b475da7c331e486d59a5608d1a0b777
"@types/node@npm:*, @types/node@npm:^16.18.24":
version: 16.18.24
resolution: "@types/node@npm:16.18.24"
checksum: 0b221b7f56f3c4911e90dfcc217db3866eb13b7af9390b8f668377f1211b2b3ca808e0128a29d0cef8aa0944523852531e827b923b35e5fa9063db87af7b41a0
languageName: node
linkType: hard

Expand Down