Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused networkType configuration #1359

Merged
merged 1 commit into from
May 10, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented May 10, 2023

Description

The networkType configuration option has been removed from the NFT controller and the tokens controller. In both cases it was unused.

Changes

@metamask/assets-controllers

  • BREAKING: Remove the networkType configuration option from NftController and TokensController

References

This relates to #1209

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc)
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

The `networkType` configuration option has been removed from the NFT
controller and the tokens controller. In both cases it was unused.

This relates to #1209
@Gudahtt Gudahtt force-pushed the remove-unused-network-type-configurations branch from a92ab84 to 08ad0b8 Compare May 10, 2023 13:15
@Gudahtt Gudahtt marked this pull request as ready for review May 10, 2023 14:11
@Gudahtt Gudahtt requested a review from a team as a code owner May 10, 2023 14:12
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gudahtt Gudahtt merged commit 0f9ef4f into main May 10, 2023
@Gudahtt Gudahtt deleted the remove-unused-network-type-configurations branch May 10, 2023 15:28
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
The `networkType` configuration option has been removed from the NFT
controller and the tokens controller. In both cases it was unused.

This relates to #1209
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
The `networkType` configuration option has been removed from the NFT
controller and the tokens controller. In both cases it was unused.

This relates to #1209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants