Support NFT detection on custom Mainnet RPC endpoints #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
support-custom-rpc-mainnet-nft-detection
branch
from
e897f11
to
04067a5
Compare
3 tasks
Base automatically changed from
remove-unused-network-type-configurations
to
main
May 10, 2023 15:28
Gudahtt
force-pushed
the
support-custom-rpc-mainnet-nft-detection
branch
from
04067a5
to
1e825b7
Compare
The NFT detection controller now supports NFT detection on any Ethereum Mainnet networks, including custom RPC endpoints. Previously this was only supported on the built-in Ethereum Mainnet. This restriction was likely not intentional in the first place (at least I can't think of a reason for it). This relates to #1209
Gudahtt
force-pushed
the
support-custom-rpc-mainnet-nft-detection
branch
from
1e825b7
to
be06843
Compare
|
Confirmed locally that the linter and tests are passing; I'll merge without waiting on CI since Actions is currently broken. |
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The NFT detection controller now supports NFT detection on any Ethereum Mainnet networks, including custom RPC endpoints. Previously this was only supported on the built-in Ethereum Mainnet. This restriction was likely not intentional in the first place (at least I can't think of a reason for it). This relates to #1209
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
The NFT detection controller now supports NFT detection on any Ethereum Mainnet networks, including custom RPC endpoints. Previously this was only supported on the built-in Ethereum Mainnet. This restriction was likely not intentional in the first place (at least I can't think of a reason for it). This relates to #1209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The NFT detection controller now supports NFT detection on any Ethereum Mainnet networks, including custom RPC endpoints. Previously this was only supported on the built-in Ethereum Mainnet. This restriction was likely not intentional in the first place (at least I can't think of a reason for it).
Changes
networkTypeconfiguration option from the NFT detection controllerReferences
This relates to #1209
Checklist