Initialize asset controllers with the current network #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Gudahtt
force-pushed
the
support-custom-rpc-mainnet-nft-detection
branch
2 times, most recently
from
1e825b7
to
be06843
Compare
Gudahtt
force-pushed
the
initialize-asset-controllers-with-current-network
branch
from
04b418e
to
76a0b37
Compare
Gudahtt
commented
May 10, 2023
| @@ -122,7 +122,7 @@ export interface ApiNftCreator { | |||
| */ | |||
| export interface NftDetectionConfig extends BaseConfig { | |||
| interval: number; | |||
| chainId: `0x${string}` | `${number}` | number; | |||
| chainId: string; | |||
There was a problem hiding this comment.
This is only ever set via the network controller provider config, so it has been updated to be just string, which is what the type is at the moment in the network controller. This will get more specific in an upcoming PR.
Gudahtt
force-pushed
the
initialize-asset-controllers-with-current-network
branch
from
76a0b37
to
f9683e5
Compare
|
Thank you for doing this, well-needed! I note that each controller still inlines the default chainid. Do you think it would make sense to introduce a constant |
Hmm, I'm not aware of any examples of this. Maybe I missed some cases. They are intended to have no default chain ID. |
legobeat
reviewed
May 10, 2023
mcmire
approved these changes
May 11, 2023
Certain controllers in `@metamask/assets-controllers` would default to assuming the current selected network was Ethereum Mainnet, or they'd default with an empty string as the `chainId` (causing errors if any methods were called). Instead they now all get initialized with the current chain ID, passed in as a new constructor parameter. Affected controllers are: * `AssetsContractController` * `NftController` * `NftDetectionController` * `TokenRatesController` * `TokensController` Relates to #1209
Gudahtt
force-pushed
the
initialize-asset-controllers-with-current-network
branch
from
9820305
to
d11e953
Compare
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Initialize asset controllers with the current network Certain controllers in `@metamask/assets-controllers` would default to assuming the current selected network was Ethereum Mainnet, or they'd default with an empty string as the `chainId` (causing errors if any methods were called). Instead they now all get initialized with the current chain ID, passed in as a new constructor parameter. Affected controllers are: * `AssetsContractController` * `NftController` * `NftDetectionController` * `TokenRatesController` * `TokensController` Relates to #1209 * Fix more tests
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Initialize asset controllers with the current network Certain controllers in `@metamask/assets-controllers` would default to assuming the current selected network was Ethereum Mainnet, or they'd default with an empty string as the `chainId` (causing errors if any methods were called). Instead they now all get initialized with the current chain ID, passed in as a new constructor parameter. Affected controllers are: * `AssetsContractController` * `NftController` * `NftDetectionController` * `TokenRatesController` * `TokensController` Relates to #1209 * Fix more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certain controllers in
@metamask/assets-controllerswould default to assuming the current selected network was Ethereum Mainnet, or they'd default with an empty string as thechainId(causing errors if any methods were called). Instead they now all get initialized with the current chain ID, passed in as a new constructor parameter.Affected controllers are:
AssetsContractControllerNftControllerNftDetectionControllerTokenRatesControllerTokensControllerChanges
chainIdrequired constructor parameter:AssetsContractControllerNftControllerNftDetectionControllerTokenRatesControllerTokensControllerReferences
Relates to #1209
Checklist