Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize asset controllers with the current network #1361

Merged
merged 2 commits into from
May 11, 2023
Merged

Initialize asset controllers with the current network #1361

merged 2 commits into from
May 11, 2023

Commits on May 11, 2023

  1. Initialize asset controllers with the current network 

    Certain controllers in `@metamask/assets-controllers` would default to
assuming the current selected network was Ethereum Mainnet, or they'd
default with an empty string as the `chainId` (causing errors if any
methods were called). Instead they now all get initialized with the
current chain ID, passed in as a new constructor parameter.

Affected controllers are:
* `AssetsContractController`
* `NftController`
* `NftDetectionController`
* `TokenRatesController`
* `TokensController`

Relates to #1209
    @Gudahtt
    Gudahtt committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4975365 View commit details
    Browse the repository at this point in the history

  2. Fix more tests

    @Gudahtt
    Gudahtt committed May 11, 2023
    Configuration menu
    Copy the full SHA
    d11e953 View commit details
    Browse the repository at this point in the history