-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @metamask/json-rpc-engine
and @metamask/utils
#1724
Conversation
Solved this by patching |
package.json
Outdated
"@metamask/rpc-methods@^0.38.1-flask.1": "patch:@metamask/rpc-methods@npm%3A0.38.1-flask.1#./.yarn/patches/@metamask-rpc-methods-npm-0.38.1-flask.1-081e1eb5b3.patch", | ||
"@metamask/rpc-methods@^1.0.1": "patch:@metamask/rpc-methods@npm%3A0.38.1-flask.1#./.yarn/patches/@metamask-rpc-methods-npm-0.38.1-flask.1-081e1eb5b3.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@metamask/eth-snap-keyring
and @metamask/keyring-api
need to update the version of @metamask/snaps-controllers
so we can dedupe this.
Tests are failing because we're using
And that can't be solved without changing the |
Where do you see this error? Seems fine here: |
I might've done something wrong then. 🤔 Thanks for looking into this! |
Should unlock bumping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need rebase on main
, though see note about parallel PRs with some overlapping changes to this one.
## Explanation This replaces obsolete `eth-rpc-errors` with `@metamask/rpc-errors` in `@metamask/approval-controller`. This should be coupled with #1639 and can be merged before or after. ## References #### Broken out from - #1731 #### Blocking - #1724 #### Related - #1690 ## Changelog ### `@metamask/approval-controller` - **Changed**: Replaced `eth-rpc-errors` with `@metamask/rpc-errors` ### `@metamask/controller-utils` - **Fixed**: Removed unused dependency `eth-rpc-errors` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
## Explanation This replaces obsolete `eth-rpc-errors` with `@metamask/rpc-errors` in `@metamask/approval-controller`. This should be coupled with #1639 and can be merged before or after. ## References #### Broken out from - #1731 #### Blocking - #1724 #### Related - #1690 ## Changelog ### `@metamask/approval-controller` - **Changed**: Replaced `eth-rpc-errors` with `@metamask/rpc-errors` ### `@metamask/controller-utils` - **Fixed**: Removed unused dependency `eth-rpc-errors` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
## Explanation This replaces obsolete `eth-rpc-errors` with `@metamask/rpc-errors` in `@metamask/approval-controller`. This should be coupled with #1639 and can be merged before or after. ## References #### Broken out from - #1731 #### Blocking - #1724 #### Related - #1690 ## Changelog ### `@metamask/approval-controller` - **Changed**: Replaced `eth-rpc-errors` with `@metamask/rpc-errors` ### `@metamask/controller-utils` - **Fixed**: Removed unused dependency `eth-rpc-errors` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
## Explanation This replaces obsolete `eth-rpc-errors` with `@metamask/rpc-errors` in `@metamask/approval-controller`. This should be coupled with #1639 and can be merged before or after. ## References #### Broken out from - #1731 #### Blocking - #1724 #### Related - #1690 ## Changelog ### `@metamask/approval-controller` - **Changed**: Replaced `eth-rpc-errors` with `@metamask/rpc-errors` ### `@metamask/controller-utils` - **Fixed**: Removed unused dependency `eth-rpc-errors` ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Superseded by #1749 |
Explanation
This bumps
@metamask/json-rpc-engine
(previouslyjson-rpc-engine
) and@metamask/utils
to the latest versions. This is required to be able to use the latest versions of@metamask/json-rpc-engine
and@metamask/eth-json-rpc-middleware
in Snaps (MetaMask/snaps#1781).The updated version of
@metamask/json-rpc-engine
is functionally equivalent to the previous version, but has improved types. To be able to bump it, it also required a bump of@metamask/utils
.Changelog
@metamask/accounts-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/address-book-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/approval-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/assets-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/base-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/controller-utils
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/ens-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/gas-fee-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/keyring-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/message-manager
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/network-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/notification-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/permission-controller
RestrictedMethodParameters
no longer acceptsvoid
as type.@metamask/utils
from^6.2.0
to^8.1.0
@metamask/json-rpc-engine
from^6.1.0
to^7.1.1
@metamask/signature-controller
@metamask/utils
from^6.2.0
to^8.1.0
@metamask/transaction-controller
@metamask/utils
from^6.2.0
to^8.1.0
Checklist