Align ESLint, Prettier packages and configs with core monorepo ahead of migration #28

MajorLift · 2023-09-25T18:50:54Z

Description

This PR aligns the ESLint and Prettier packages and configs in this repo with the core monorepo.
This is a preparation step for migrating the eth-json-rpc-provider package into the core monorepo.
Originally, the plan was to decrement the TypeScript version to align with the core monorepo, but following this discussion, we've opted to use TypeScript version v4.8.4, and preserve the compiler options in this package that aren't enabled in the core monorepo.

References

See Fully migrate eth-json-rpc-provider into core monorepo core#1551
Closes Update packages and configs for eslint and prettier core#1683
Closes Migrate Typescript to ~4.6.3 core#1682 (is superseded by this PR)

Next Steps

Create a new release once this PR is merged.

- match compiler options with core monorepo - passes all tests Closes #1682

…norepo - added: `eslint-plugin-promise` - removed: `eslint-plugin-node` See: MetaMask/core#1683

- added `eslint-import-resolver-typescript` v2.5.0 as dependency See: MetaMask/core#1683

socket-security · 2023-09-25T18:51:56Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
eslint-plugin-promise	6.1.1	None	`+0`	67.1 kB	eslint-community-bot
eslint-import-resolver-typescript	2.7.1	None	`+0`	59.9 kB	jounqin
eslint-plugin-n	15.7.0	filesystem	`+4`	883 kB	weiran.zsd
@metamask/eslint-config-jest	11.1.0...12.1.0	None	`+0/-3`	8.72 kB	metamaskbot
@metamask/eslint-config-typescript	11.1.0...12.1.0	None	`+0/-3`	18.5 kB	metamaskbot
@metamask/eslint-config-nodejs	11.1.0...12.1.0	None	`+5/-5`	978 kB	metamaskbot

🚮 Removed packages: @lavamoat/allow-scripts@2.0.3, @metamask/eslint-config@11.1.0, eslint-plugin-node@11.1.0

Mrtenz · 2023-09-25T20:32:41Z

See my comments on #27.

socket-security · 2023-09-25T21:19:59Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: which@3.0.1, nopt@6.0.0, @lavamoat/aa@3.1.5

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

MajorLift · 2023-09-25T21:24:36Z

@SocketSecurity ignore which@3.0.1
@SocketSecurity ignore nopt@6.0.0
@SocketSecurity ignore @lavamoat/aa@3.1.5

…e monorepo - See MetaMask/core#1718 - See #27 - Closes MetaMask/core#1682

…monorepo

Gudahtt

LGTM!

legobeat · 2023-09-28T00:41:10Z

package.json

-    "@types/node": "^16.18.39",
-    "@typescript-eslint/eslint-plugin": "^5.43.0",
-    "@typescript-eslint/parser": "^5.43.0",
+    "@types/node": "^16.18.24",


FYI: The devDeps being dropped here are inversely pending bumps in core here: MetaMask/core#1740

## Explanation This is the first of two PRs that will migrate [`eth-json-rpc-provider`](https://github.com/MetaMask/eth-json-rpc-provider) into the core monorepo by following these steps: #1079 (comment). - This PR focuses on migrating the git history of the original package. - `eth-json-rpc-provider` is moved into a temporary directory in core (`merged-packages/`) with git history fully intact. - The second PR will remove the `merged-packages/` directory and integrate `eth-json-rpc-provider` into the `packages/` directory, resolving any issues arising from applying core monorepo linter/compiler/build settings to the newly added package. ## Blocked by - [x] MetaMask/eth-json-rpc-provider#29 ## References - Partially implements #1551 - See MetaMask/eth-json-rpc-provider#28 for preparatory steps taken in original repo. ## Changelog N/A since `@metamask/eth-json-rpc-provider` isn't usable from the monorepo as of this PR. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Alex Donesky <alex.donesky@consensys.net> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: legobt <6wbvkn0j@anonaddy.me> Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>

MajorLift added 4 commits September 25, 2023 11:28

Decrement TypeScript to ~4.6.3 ahead of migration to core monorepo

fb5c792

- match compiler options with core monorepo - passes all tests Closes #1682

Update packages for eslint and prettier ahead of migration to core mo…

32b7d1a

…norepo - added: `eslint-plugin-promise` - removed: `eslint-plugin-node` See: MetaMask/core#1683

linter fix from eslint version update

37cd1df

Apply core monorepo eslint config

ea3cfa2

- added `eslint-import-resolver-typescript` v2.5.0 as dependency See: MetaMask/core#1683

MajorLift requested a review from a team as a code owner September 25, 2023 18:50

MajorLift mentioned this pull request Sep 25, 2023

Decrement TypeScript to ~4.6.3 ahead of migration to core monorepo #27

Closed

Bump dependency versions to align with core monorepo v77.0.0

f1fcb2b

MajorLift force-pushed the 230925-migrate-to-monorepo-deps-linter-configs branch from 0c07937 to f1fcb2b Compare September 25, 2023 21:18

MajorLift marked this pull request as draft September 26, 2023 15:39

Bump TypeScript to v4.8.4 to align with planned version update in cor…

eecfb70

…e monorepo - See MetaMask/core#1718 - See #27 - Closes MetaMask/core#1682

MajorLift marked this pull request as ready for review September 26, 2023 16:07

MajorLift self-assigned this Sep 26, 2023

MajorLift added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 26, 2023

Restore TypeScript compiler options that are not enabled in the core …

67d0db4

…monorepo

MajorLift mentioned this pull request Sep 26, 2023

deps: @metamask/utils@^6.2.0->^8.1.0 MetaMask/core#1639

Merged

3 tasks

MajorLift force-pushed the 230925-migrate-to-monorepo-deps-linter-configs branch 2 times, most recently from bbdef60 to 67d0db4 Compare September 26, 2023 21:40

MajorLift mentioned this pull request Sep 27, 2023

Migrate eth-json-rpc-provider into core monorepo (1/2) MetaMask/core#1737

Merged

4 tasks

MajorLift requested review from Mrtenz, mikesposito and cryptodev-2s September 27, 2023 18:05

MajorLift mentioned this pull request Sep 27, 2023

eth-json-rpc-provider migration - Integration into packages/ MetaMask/core#1738

Merged

33 tasks

Gudahtt approved these changes Sep 27, 2023

View reviewed changes

legobeat reviewed Sep 28, 2023

View reviewed changes

legobeat approved these changes Sep 28, 2023

View reviewed changes

MajorLift merged commit aab4c50 into main Sep 28, 2023
31 checks passed

MajorLift deleted the 230925-migrate-to-monorepo-deps-linter-configs branch September 28, 2023 16:33

This was referenced Oct 2, 2023

Migrate eth-json-rpc-provider into core monorepo (1/2) MetaMask/core#1755

Merged

Fully migrate eth-json-rpc-provider into core monorepo MetaMask/core#1551

Closed

georgewrmarshall mentioned this pull request Nov 8, 2024

Align dependency versions and TypeScript, ESLint, Prettier configurations with the metamask module template MetaMask/design-tokens#746

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align ESLint, Prettier packages and configs with core monorepo ahead of migration #28

Align ESLint, Prettier packages and configs with core monorepo ahead of migration #28

MajorLift commented Sep 25, 2023 •

edited

Loading

socket-security bot commented Sep 25, 2023 •

edited

Loading

Mrtenz commented Sep 25, 2023

socket-security bot commented Sep 25, 2023 •

edited

Loading

MajorLift commented Sep 25, 2023

Gudahtt left a comment

legobeat Sep 28, 2023

Align ESLint, Prettier packages and configs with core monorepo ahead of migration #28

Align ESLint, Prettier packages and configs with core monorepo ahead of migration #28

Conversation

MajorLift commented Sep 25, 2023 • edited Loading

Description

References

Next Steps

socket-security bot commented Sep 25, 2023 • edited Loading

Mrtenz commented Sep 25, 2023

socket-security bot commented Sep 25, 2023 • edited Loading

Next steps

MajorLift commented Sep 25, 2023

Gudahtt left a comment

Choose a reason for hiding this comment

legobeat Sep 28, 2023

Choose a reason for hiding this comment

MajorLift commented Sep 25, 2023 •

edited

Loading

socket-security bot commented Sep 25, 2023 •

edited

Loading

socket-security bot commented Sep 25, 2023 •

edited

Loading