Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: @metamask/eslint-config*->12.1.0 #1740

Merged
merged 11 commits into from
Oct 2, 2023

Conversation

legobeat
Copy link
Contributor

Explanation

  • Bump @metamask/eslint-config* packages to latest.
    • Bump typedoc,typedoc-plugin-missing-exports to satisfy peerDeps

References

Related

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security
Copy link

socket-security bot commented Sep 27, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
typedoc-plugin-missing-exports 0.23.0...2.1.0 None +25/-50 30.5 MB gerrit0
eslint-plugin-import 2.28.1...2.26.0 None +2/-49 1.12 MB ljharb
typedoc 0.23.28...0.24.8 None +0/-25 1.22 MB typedoc-bot

@legobeat legobeat marked this pull request as ready for review September 27, 2023 23:13
@legobeat legobeat requested review from a team as code owners September 27, 2023 23:13
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 27, 2023
Gudahtt
Gudahtt previously approved these changes Sep 27, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat
Copy link
Contributor Author

@MetaMask/snaps-devs needs your approval :)

@legobeat
Copy link
Contributor Author

legobeat commented Sep 28, 2023

Updated with bumping range for @typescript-eslint/eslint-plugin and @typescript-eslint/parser. 394e323

These were already at the most recent versions in lockfile so this does not make a difference in practice but done for sake of smooth migrations of other packages into this monorepo.

Gudahtt
Gudahtt previously approved these changes Sep 28, 2023
Mrtenz
Mrtenz previously approved these changes Sep 28, 2023
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically unrelated to your change, but we should fix this.

@legobeat legobeat dismissed stale reviews from Mrtenz and Gudahtt via 8826e02 September 28, 2023 21:47
MajorLift
MajorLift previously approved these changes Sep 28, 2023
MajorLift
MajorLift previously approved these changes Sep 29, 2023
@legobeat legobeat requested review from a team September 29, 2023 04:39
Mrtenz
Mrtenz previously approved these changes Sep 29, 2023
@legobeat legobeat dismissed stale reviews from MajorLift and Mrtenz via aece1e0 September 30, 2023 01:50
@legobeat legobeat force-pushed the devDeps-typescript-eslint-configs branch from 421869f to aece1e0 Compare September 30, 2023 01:50
@legobeat legobeat requested review from Mrtenz, MajorLift and a team September 30, 2023 01:58
@legobeat legobeat requested review from a team October 2, 2023 00:26
@legobeat legobeat merged commit 53c6b76 into MetaMask:main Oct 2, 2023
107 checks passed
@legobeat legobeat deleted the devDeps-typescript-eslint-configs branch October 2, 2023 00:26
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
## Explanation

- Bump `@metamask/eslint-config*` packages to latest.
  - Bump `typedoc`,`typedoc-plugin-missing-exports` to satisfy peerDeps

## References

#### Related
- #1730
- #1718 
 
## Changelog

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

---------

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
## Explanation

- Bump `@metamask/eslint-config*` packages to latest.
  - Bump `typedoc`,`typedoc-plugin-missing-exports` to satisfy peerDeps

## References

#### Related
- #1730
- #1718 
 
## Changelog

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

---------

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
MajorLift pushed a commit that referenced this pull request Oct 12, 2023
## Explanation

- Bump `@metamask/eslint-config*` packages to latest.
  - Bump `typedoc`,`typedoc-plugin-missing-exports` to satisfy peerDeps

## References

#### Related
- #1730
- #1718 
 
## Changelog

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

---------

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants