feat: add externalLinkClicked to TransactionMetaBase type #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
digiwand
commented
Jan 24, 2024
jpuri
approved these changes
Jan 25, 2024
digiwand
deleted the
feat-add-external-link-clicked-to-TransactionMetaBase
branch
digiwand
added a commit
that referenced
this pull request
Jan 26, 2024
…3854) Reverts #3828 no longer needed after discovering we can update the event fragment ad-hoc using the useTransactionEventFragment hook Related to MetaMask/metamask-extension#22631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This prop is used to pass a value used to be added as a transaction metametric fragment prop.
References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/1756
Related to MetaMask/metamask-extension#22631
Changelog
@metamask/transaction-controllerexternalLinkClickedprop to TransactionMetaBase typeChecklist