Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: add externalLinkClicked to TransactionMetaBase type" #3854

Conversation

digiwand
Copy link
Contributor

Reverts #3828

no longer needed after discovering we can update the event fragment ad-hoc using the useTransactionEventFragment hook

Related to MetaMask/metamask-extension#22631

@digiwand digiwand requested a review from a team as a code owner January 26, 2024 02:10
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@digiwand digiwand merged commit ac18b9c into main Jan 26, 2024
136 checks passed
@digiwand digiwand deleted the revert-3828-feat-add-external-link-clicked-to-TransactionMetaBase branch January 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants