fix: init waits for the iframe to be loaded
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesposito
changed the title
init waits for the iframe to be loaded
mikesposito
commented
Jul 24, 2024
mikesposito
commented
Jul 25, 2024
Comment on lines
+4
to
+7
| const shim = { | ||
| head: { | ||
| appendChild: (child: { onload?: () => void }) => { | ||
| child.onload?.(); |
There was a problem hiding this comment.
documentShim.head.appendChild seems to be the best place to forge the iframe onload. I removed some code from tests that was intended to do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
updateTransportMethodstores a promise in a class variable that will resolve only when the iframe is loaded. Though, there are instances when this mechanism is broken - like whenupdateTransportMethodis called multiple times.This PR changes the
initmethod to wait for the iframe to be fully loaded before resolving. This implies that whenupdateTransportMethodis called, the bridge needs to be already initialized (withinit), or an error is thrownFixes #70