Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Upgrade ethereumjs-util library to latest version #65

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

brad-decker
Copy link
Contributor

This upgrade includes changes in ethereumjs-util that removes a dependency on a library that we no longer wish to include, and sets us up for future dependency upgrades. The only change required to get passing tests (and issue a transaction through the extension using yarn link) was to prefix the address string in one method.

@brad-decker brad-decker marked this pull request as ready for review March 25, 2021 19:00
@brad-decker brad-decker requested a review from a team as a code owner March 25, 2021 19:00
NiranjanaBinoy
NiranjanaBinoy previously approved these changes Mar 25, 2021
Copy link

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@brad-decker brad-decker merged commit bd9ba9c into main Apr 14, 2021
@brad-decker brad-decker deleted the upgrade-ethereumjs-util branch April 14, 2021 19:40
julianariel pushed a commit to block-wallet/eth-ledger-bridge-keyring that referenced this pull request Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants