Support EIP-2718 transaction types, EIP-2930 and EIP-1559 support #11288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
force-pushed
the
ethereumjs-tx-upgrade
branch
from
9876df0
to
2a2d6ea
Compare
Builds ready [2a2d6ea]
Page Load Metrics (573 ± 53 ms)
|
brad-decker
force-pushed
the
ethereumjs-tx-upgrade
branch
from
2a2d6ea
to
c7fea9b
Compare
Builds ready [c7fea9b]
Page Load Metrics (635 ± 77 ms)
|
brad-decker
changed the title
rickycodes
previously approved these changes
Jun 15, 2021
brad-decker
requested review from
darkwing and
ryanml
and removed request for
adonesky1
darkwing
reviewed
Jun 15, 2021
|
|
||
| const customChainParams = { | ||
| name: nickname, | ||
| chainId: parseInt(chainId, 16), |
There was a problem hiding this comment.
Minor but can we use parseInt when we first create the variable, since it's not used as a string in this function? Would be cool to know its type right away. Not a blocker, just a suggestion.
There was a problem hiding this comment.
@darkwing done in latest. Also renamed nickname -> name during destructuring
darkwing
previously approved these changes
Jun 15, 2021
ryanml
reviewed
Jun 15, 2021
| return Common.forCustomChain('mainnet', customChainParams, HARDFORK); | ||
| } | ||
|
|
||
| return new Common({ chain: type, hardfork: HARDFORK }); |
There was a problem hiding this comment.
Also minor, (and our linter may not like this, I forget) Can we check for type !== 'rpc' at the top of the function and return new Common({ chain: type, hardfork: HARDFORK }); immediately, then we don't have to have the rpc type logic in a conditional? Totally minor and probably too picky :)
There was a problem hiding this comment.
Done! Good call. I also changed 'rpc' -> NETWORK_TYPE_RPC
brad-decker
dismissed stale reviews from ryanml, darkwing, and rickycodes
via
63e43c5
Builds ready [b876ed5]
Page Load Metrics (544 ± 48 ms)
|
Builds ready [b5e806b]
Page Load Metrics (624 ± 45 ms)
|
rickycodes
approved these changes
Jun 16, 2021
darkwing
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Code makes sense and all my manual testing worked great! Thank you @brad-decker !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-2718 Support via @ethereumjs/tx
Up until this PR we have used a locked version of ethereumjs-tx, which has been deprecated in favor of the namespace @ethereumjs/tx. The following work was done as a prerequisite for this PR to be able to be merged:
This PR gets us onto the newest version of @etheruemjs/tx which includes support for EIP-2718, EIP-2930, and EIP-1559. No UI modification is included in this PR, sending transactions in MetaMask will still use legacy (type 0) transactions.
@ethereumjs/common
This PR also implements the Common library from ethereumjs which helps to instantiate the different types of chain parameters that can affect which types of transactions work on which chains. In this version of @ethereumjs/tx you must use
TransactionFactory.fromTxDatato create a transaction. This factory method references which chain, hardfork and EIPs are currently supported then analyzes the txParams to build the appropriate type of transaction.Updates were necessary in our
signTransactionmethod, as well as in a few test files.