Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: add scenario sign typed v3 with hardware wallet (#23063)
## **Description** In this PR we add the scenario for the flow: sign typed v3 with hardware wallet. Note: sign typed data v3 only work with QR-based wallets, not with Trezor nor Ledger. This task belongs to the effort of documenting manual QA flows[ in this Epic](#21962). ## **Related issues** Fixes: #22028 ## **Manual testing steps** Check steps are coherent with the flow in the video (at the end of the video the signature is closed due to a current identified [issue](#23074)) Note: You can see the table rendered [here](https://github.com/MetaMask/metamask-extension/blob/1c387482f46acd9c1fd16b26f44acea9817152d6/test/scenarios/13.%20sign/sign%20typed%20data%20v3%20with%20hardware%20wallet.csv) for an easier review ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/54408225/322eda2a-5e5d-411b-bd17-29dd46cb137b ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information