Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add scenario sign typed v3 with hardware wallet #23063

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Feb 20, 2024

Description

In this PR we add the scenario for the flow: sign typed v3 with hardware wallet. Note: sign typed data v3 only work with QR-based wallets, not with Trezor nor Ledger.
This task belongs to the effort of documenting manual QA flows in this Epic.

Related issues

Fixes: #22028

Manual testing steps

Check steps are coherent with the flow in the video (at the end of the video the signature is closed due to a current identified issue)
Note: You can see the table rendered here for an easier review

Screenshots/Recordings

signv3-qr.mp4

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona added the team-confirmations-secure-ux-PR PRs from the confirmations team label Feb 20, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef9e63a) 68.48% compared to head (e6a847a) 68.48%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23063   +/-   ##
========================================
  Coverage    68.48%   68.48%           
========================================
  Files         1089     1089           
  Lines        43015    43015           
  Branches     11462    11462           
========================================
  Hits         29455    29455           
  Misses       13560    13560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e6a847a]
Page Load Metrics (1059 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1124021996129
domContentLoaded1085422512
load7761398105914570
domInteractive1085422512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona closed this Feb 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2024
@seaona seaona reopened this Feb 20, 2024
@seaona seaona marked this pull request as ready for review February 20, 2024 14:42
@seaona seaona requested a review from a team as a code owner February 20, 2024 14:42
@metamaskbot
Copy link
Collaborator

Builds ready [bb53ca9]
Page Load Metrics (1072 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892791884723
domContentLoaded1173362412
load7571300107210048
domInteractive1173362412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona merged commit be604fc into develop Feb 21, 2024
66 checks passed
@seaona seaona deleted the test-scenario-sign3-hw branch February 21, 2024 07:52
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardware wallet: Sign Typed Data V3
5 participants