-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add scenario sign typed v3 with hardware wallet #23063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23063 +/- ##
========================================
Coverage 68.48% 68.48%
========================================
Files 1089 1089
Lines 43015 43015
Branches 11462 11462
========================================
Hits 29455 29455
Misses 13560 13560 ☔ View full report in Codecov by Sentry. |
Builds ready [e6a847a]
Page Load Metrics (1059 ± 70 ms)
Bundle size diffs
|
jpuri
approved these changes
Feb 20, 2024
jpuri
approved these changes
Feb 20, 2024
segun
approved these changes
Feb 20, 2024
sleepytanya
approved these changes
Feb 20, 2024
Builds ready [bb53ca9]
Page Load Metrics (1072 ± 48 ms)
Bundle size diffs
|
metamaskbot
added
the
release-11.12.0
Issue or pull request that will be included in release 11.12.0
label
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.12.0
Issue or pull request that will be included in release 11.12.0
team-confirmations-secure-ux-PR
PRs from the confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we add the scenario for the flow: sign typed v3 with hardware wallet. Note: sign typed data v3 only work with QR-based wallets, not with Trezor nor Ledger.
This task belongs to the effort of documenting manual QA flows in this Epic.
Related issues
Fixes: #22028
Manual testing steps
Check steps are coherent with the flow in the video (at the end of the video the signature is closed due to a current identified issue)
Note: You can see the table rendered here for an easier review
Screenshots/Recordings
signv3-qr.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist