Skip to content

Commit

Permalink
Bump assets controllers to v24 (#22478)
Browse files Browse the repository at this point in the history
## **Description**

Bumps assets controllers to v24. Brings in change to reduce batch size
of calls to price API (MetaMask/core#3753)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#1891

## **Manual testing steps**

- Ensure that token prices in fiat still appear on home page

## **Screenshots/Recordings**

No visible differences

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
bergeron authored Jan 10, 2024
1 parent ff3c523 commit f34cb36
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@
"@metamask/address-book-controller": "^3.0.0",
"@metamask/announcement-controller": "^4.0.0",
"@metamask/approval-controller": "^5.1.0",
"@metamask/assets-controllers": "^23.0.0",
"@metamask/assets-controllers": "^24.0.0",
"@metamask/base-controller": "^4.0.0",
"@metamask/browser-passworder": "^4.3.0",
"@metamask/contract-metadata": "^2.3.1",
Expand Down
22 changes: 11 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3828,9 +3828,9 @@ __metadata:
languageName: node
linkType: hard

"@metamask/assets-controllers@npm:^23.0.0":
version: 23.1.0
resolution: "@metamask/assets-controllers@npm:23.1.0"
"@metamask/assets-controllers@npm:^24.0.0":
version: 24.0.0
resolution: "@metamask/assets-controllers@npm:24.0.0"
dependencies:
"@ethersproject/address": "npm:^5.7.0"
"@ethersproject/bignumber": "npm:^5.7.0"
Expand All @@ -3845,7 +3845,7 @@ __metadata:
"@metamask/metamask-eth-abis": "npm:3.0.0"
"@metamask/network-controller": "npm:^17.1.0"
"@metamask/polling-controller": "npm:^4.0.0"
"@metamask/preferences-controller": "npm:^5.0.1"
"@metamask/preferences-controller": "npm:^6.0.0"
"@metamask/rpc-errors": "npm:^6.1.0"
"@metamask/utils": "npm:^8.2.0"
"@types/uuid": "npm:^8.3.0"
Expand All @@ -3859,8 +3859,8 @@ __metadata:
peerDependencies:
"@metamask/approval-controller": ^5.1.1
"@metamask/network-controller": ^17.1.0
"@metamask/preferences-controller": ^5.0.1
checksum: 2aae427b6a63c20f9521b20b47c2b3b8771eaa35fbcf4c66b36a263eb12bee62484238ae4c34551020254b0f2c0eb9ead26a47051eb16d696abaff830a357af9
"@metamask/preferences-controller": ^6.0.0
checksum: f9c857e26e04ca8463421434fad3096161d24e776da85c136689ac93a402f9cdafc175c8bd11b64a93d0d38d54109a541fedfee0d93b9e7eb1e1372904b68694
languageName: node
linkType: hard

Expand Down Expand Up @@ -4754,13 +4754,13 @@ __metadata:
languageName: node
linkType: hard

"@metamask/preferences-controller@npm:^5.0.1":
version: 5.0.1
resolution: "@metamask/preferences-controller@npm:5.0.1"
"@metamask/preferences-controller@npm:^6.0.0":
version: 6.0.0
resolution: "@metamask/preferences-controller@npm:6.0.0"
dependencies:
"@metamask/base-controller": "npm:^4.0.1"
"@metamask/controller-utils": "npm:^8.0.1"
checksum: 393088eff97375a70d197627ee45bdca681253c397da96005784b0aecb0611762c899594471158af9403feef6587d2a1e92a85ca5010369f65ddd3af782e5c7c
checksum: 963df49ff9f79204586ee38873823d11d4c75587212e0a9c8c835f9fbdbbaeadebe34fe635d36b3e9cb3d3cf9f4ecf3ddc0fec6ec366284294b01b2420cde895
languageName: node
linkType: hard

Expand Down Expand Up @@ -24633,7 +24633,7 @@ __metadata:
"@metamask/address-book-controller": "npm:^3.0.0"
"@metamask/announcement-controller": "npm:^4.0.0"
"@metamask/approval-controller": "npm:^5.1.0"
"@metamask/assets-controllers": "npm:^23.0.0"
"@metamask/assets-controllers": "npm:^24.0.0"
"@metamask/auto-changelog": "npm:^2.1.0"
"@metamask/base-controller": "npm:^4.0.0"
"@metamask/browser-passworder": "npm:^4.3.0"
Expand Down

0 comments on commit f34cb36

Please sign in to comment.