Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump assets controllers to v24 #22478

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Jan 10, 2024

Description

Bumps assets controllers to v24. Brings in change to reduce batch size of calls to price API (MetaMask/core#3753)

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1891

Manual testing steps

  • Ensure that token prices in fiat still appear on home page

Screenshots/Recordings

No visible differences

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner January 10, 2024 15:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron merged commit f34cb36 into develop Jan 10, 2024
69 of 71 checks passed
@bergeron bergeron deleted the brian/upgrade-assets-controllers-24 branch January 10, 2024 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
@metamaskbot metamaskbot added release-11.9.0 Issue or pull request that will be included in release 11.9.0 release-11.7.4 Issue or pull request that will be included in release 11.7.4 and removed release-11.9.0 Issue or pull request that will be included in release 11.9.0 labels Jan 10, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.7.4 on PR. Adding release label release-11.7.4 on PR and removing other release labels(release-11.9.0), as PR was cherry-picked in branch 11.7.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.7.4 Issue or pull request that will be included in release 11.7.4 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants