Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware wallet: Personal Sign #22027

Closed
chloeYue opened this issue Nov 23, 2023 · 1 comment · Fixed by #23314
Closed

Hardware wallet: Personal Sign #22027

chloeYue opened this issue Nov 23, 2023 · 1 comment · Fixed by #23314
Assignees
@segun @seaona
Labels
area-documentation Issues relating to documentation, in the codebase and off. INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead

Comments

@chloeYue
Copy link
Contributor

No description provided.

@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Nov 23, 2023
@chloeYue chloeYue added area-documentation Issues relating to documentation, in the codebase and off. team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-system DEPRECATED: please use "team-confirmations" label instead and removed team-extension-platform labels Nov 23, 2023
@bschorchit bschorchit added team-confirmations-planning (only for internal use within Confirmations team) and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels Nov 24, 2023
@seaona seaona added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead and removed team-confirmations-planning (only for internal use within Confirmations team) labels Feb 5, 2024
@seaona seaona self-assigned this Feb 5, 2024
@seaona
Copy link
Contributor

seaona commented Mar 1, 2024

Example PRs on a similar task:

@segun segun self-assigned this Mar 5, 2024
@segun segun mentioned this issue Mar 5, 2024
Merged
13 tasks
segun added a commit that referenced this issue Mar 14, 2024
@segun
test: add scenario for personal sign using hardware wallet (#23314)
9dfde3b 
## **Description**
In this PR we add the scenario for the flow: eth sign with hardware
wallet.
This task belongs to the effort of documenting manual QA flows[ in this
Epic](#21962).


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/23314?quickstart=1)

## **Related issues**

Fixes: #22027 

## **Manual testing steps**

1. Check the video below.

## **Screenshots/Recordings**
Performing the steps defined in the scenario


https://github.com/MetaMask/metamask-extension/assets/44811/ed18a2d7-7862-481f-aa7c-bb3d011fc440

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 14, 2024
davidmurdoch pushed a commit that referenced this issue Mar 14, 2024
@segun @davidmurdoch
test: add scenario for personal sign using hardware wallet (#23314)
a873c1b 
## **Description**
In this PR we add the scenario for the flow: eth sign with hardware
wallet.
This task belongs to the effort of documenting manual QA flows[ in this
Epic](#21962).


[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/23314?quickstart=1)

## **Related issues**

Fixes: #22027 

## **Manual testing steps**

1. Check the video below.

## **Screenshots/Recordings**
Performing the steps defined in the scenario


https://github.com/MetaMask/metamask-extension/assets/44811/ed18a2d7-7862-481f-aa7c-bb3d011fc440

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@segun segun

@seaona seaona

Labels
area-documentation Issues relating to documentation, in the codebase and off. INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add scenario for personal sign using hardware wallet MetaMask/metamask-extension
5 participants
@segun @bschorchit @metamaskbot @seaona @chloeYue