-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dragging seed phrase during Confirm Seed Phrase #6557
Conversation
chikeichan
commented
May 3, 2019
•
edited
Loading
edited
- Implement feature
- Add unit test
- Fix/Update Integration test
cc @bdresser |
@chikeichan I made a demo of the draggable feature for styling purposes. Using our current design system button styles to see how it feels and I think it could work. Clickable demo version here: https://codepen.io/cjeria/pen/dEbMwg And a gif (ignore the horizontally expanding parent container and font family). |
Not gone -
will fix in next commit
will fix in next commit
Thanks for the demo! What does it mean for specific changes on this PR? I can see that there are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! I have not QA'd yet.
And as for the default state of the unselected words, let's go with a combo button style. I'll add to the design system as button-toggle. @chikeichan |
Looks good! Approved! |