Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dragging seed phrase during Confirm Seed Phrase #6557

Merged
merged 11 commits into from
May 7, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
401 changes: 251 additions & 150 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@
"ramda": "^0.24.1",
"react": "^15.6.2",
"react-addons-css-transition-group": "^15.6.0",
"react-dnd": "^3.0.2",
"react-dnd-html5-backend": "^7.4.4",
"react-dom": "^15.6.2",
"react-hyperscript": "^3.0.0",
"react-inspector": "^2.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import {
INITIALIZE_SEED_PHRASE_ROUTE,
} from '../../../../helpers/constants/routes'
import { exportAsFile } from '../../../../helpers/utils/util'
import { selectSeedWord, deselectSeedWord } from './confirm-seed-phrase.state'
import DraggableSeed from './draggable-seed.component'

const EMPTY_SEEDS = Array(12).fill(null)

export default class ConfirmSeedPhrase extends PureComponent {
static contextTypes = {
Expand All @@ -27,10 +29,32 @@ export default class ConfirmSeedPhrase extends PureComponent {
}

state = {
selectedSeedWords: [],
selectedSeedIndices: [],
shuffledSeedWords: [],
// Hash of shuffledSeedWords index {Number} to selectedSeedWords index {Number}
selectedSeedWordsHash: {},
pendingSeedIndices: [],
draggingSeedIndex: -1,
hoveringIndex: -1,
isDragging: false,
}

shouldComponentUpdate (nextProps, nextState, nextContext) {
const { seedPhrase } = this.props
const {
selectedSeedIndices,
shuffledSeedWords,
pendingSeedIndices,
draggingSeedIndex,
hoveringIndex,
isDragging,
} = this.state

return seedPhrase !== nextProps.seedPhrase ||
draggingSeedIndex !== nextState.draggingSeedIndex ||
isDragging !== nextState.isDragging ||
hoveringIndex !== nextState.hoveringIndex ||
selectedSeedIndices.join(' ') !== nextState.selectedSeedIndices.join(' ') ||
shuffledSeedWords.join(' ') !== nextState.shuffledSeedWords.join(' ') ||
pendingSeedIndices.join(' ') !== nextState.pendingSeedIndices.join(' ')
}

componentDidMount () {
Expand All @@ -39,6 +63,26 @@ export default class ConfirmSeedPhrase extends PureComponent {
this.setState({ shuffledSeedWords })
}

setDraggingSeedIndex = draggingSeedIndex => this.setState({ draggingSeedIndex })

setHoveringIndex = hoveringIndex => this.setState({ hoveringIndex })

onDrop = targetIndex => {
const {
selectedSeedIndices,
draggingSeedIndex,
} = this.state

const indices = insert(selectedSeedIndices, draggingSeedIndex, targetIndex, true)

this.setState({
selectedSeedIndices: indices,
pendingSeedIndices: indices,
draggingSeedIndex: -1,
hoveringIndex: -1,
})
}

handleExport = () => {
exportAsFile('MetaMask Secret Backup Phrase', this.props.seedPhrase, 'text/plain')
}
Expand All @@ -65,23 +109,34 @@ export default class ConfirmSeedPhrase extends PureComponent {
}

handleSelectSeedWord = (word, shuffledIndex) => {
this.setState(selectSeedWord(word, shuffledIndex))
this.setState({
selectedSeedIndices: [...this.state.selectedSeedIndices, shuffledIndex],
pendingSeedIndices: [...this.state.pendingSeedIndices, shuffledIndex],
})
}

handleDeselectSeedWord = shuffledIndex => {
this.setState(deselectSeedWord(shuffledIndex))
this.setState({
selectedSeedIndices: this.state.selectedSeedIndices.filter(i => shuffledIndex !== i),
pendingSeedIndices: this.state.pendingSeedIndices.filter(i => shuffledIndex !== i),
})
}

isValid () {
const { seedPhrase } = this.props
const { selectedSeedWords } = this.state
const { selectedSeedIndices, shuffledSeedWords } = this.state
const selectedSeedWords = selectedSeedIndices.map(i => shuffledSeedWords[i])
return seedPhrase === selectedSeedWords.join(' ')
}

render () {
const { t } = this.context
const { history } = this.props
const { selectedSeedWords, shuffledSeedWords, selectedSeedWordsHash } = this.state
const {
selectedSeedIndices,
shuffledSeedWords,
draggingSeedIndex,
} = this.state

return (
<div className="confirm-seed-phrase">
Expand All @@ -102,41 +157,39 @@ export default class ConfirmSeedPhrase extends PureComponent {
<div className="first-time-flow__text-block">
{ t('selectEachPhrase') }
</div>
<div className="confirm-seed-phrase__selected-seed-words">
{
selectedSeedWords.map((word, index) => (
<div
key={index}
className="confirm-seed-phrase__seed-word"
>
{ word }
</div>
))
}
<div
className={classnames('confirm-seed-phrase__selected-seed-words', {
'confirm-seed-phrase__selected-seed-words--dragging': draggingSeedIndex > -1,
})}
>
{ this.renderPendingSeeds() }
{ this.renderSelectedSeeds() }
</div>
<div className="confirm-seed-phrase__shuffled-seed-words">
{
shuffledSeedWords.map((word, index) => {
const isSelected = index in selectedSeedWordsHash
const isSelected = selectedSeedIndices.includes(index)

return (
<div
<DraggableSeed
key={index}
className={classnames(
'confirm-seed-phrase__seed-word',
'confirm-seed-phrase__seed-word--shuffled',
{ 'confirm-seed-phrase__seed-word--selected': isSelected }
)}
seedIndex={index}
index={index}
draggingSeedIndex={this.state.draggingSeedIndex}
setDraggingSeedIndex={this.setDraggingSeedIndex}
setHoveringIndex={this.setHoveringIndex}
onDrop={this.onDrop}
className="confirm-seed-phrase__seed-word--shuffled"
selected={isSelected}
onClick={() => {
if (!isSelected) {
this.handleSelectSeedWord(word, index)
} else {
this.handleDeselectSeedWord(index)
}
}}
>
{ word }
</div>
word={word}
/>
)
})
}
Expand All @@ -152,4 +205,80 @@ export default class ConfirmSeedPhrase extends PureComponent {
</div>
)
}

renderSelectedSeeds () {
const { shuffledSeedWords, selectedSeedIndices, draggingSeedIndex } = this.state
return EMPTY_SEEDS.map((_, index) => {
const seedIndex = selectedSeedIndices[index]
const word = shuffledSeedWords[seedIndex]

return (
<DraggableSeed
key={`selected-${seedIndex}-${index}`}
className="confirm-seed-phrase__selected-seed-words__selected-seed"
index={index}
seedIndex={seedIndex}
word={word}
draggingSeedIndex={draggingSeedIndex}
setDraggingSeedIndex={this.setDraggingSeedIndex}
setHoveringIndex={this.setHoveringIndex}
onDrop={this.onDrop}
draggable
/>
)
})
}

renderPendingSeeds () {
const {
pendingSeedIndices,
shuffledSeedWords,
draggingSeedIndex,
hoveringIndex,
} = this.state

const indices = insert(pendingSeedIndices, draggingSeedIndex, hoveringIndex)

return EMPTY_SEEDS.map((_, index) => {
const seedIndex = indices[index]
const word = shuffledSeedWords[seedIndex]

return (
<DraggableSeed
key={`pending-${seedIndex}-${index}`}
index={index}
className={classnames('confirm-seed-phrase__selected-seed-words__pending-seed', {
'confirm-seed-phrase__seed-word--hidden': draggingSeedIndex === seedIndex && index !== hoveringIndex,
})}
seedIndex={seedIndex}
word={word}
draggingSeedIndex={draggingSeedIndex}
setDraggingSeedIndex={this.setDraggingSeedIndex}
setHoveringIndex={this.setHoveringIndex}
onDrop={this.onDrop}
droppable={!!word}
/>
)
})
}
}

function insert (list, value, target, removeOld) {
let nextList = [...list]

if (typeof list[target] === 'number') {
nextList = [...list.slice(0, target), value, ...list.slice(target)]
}

if (removeOld) {
nextList = nextList.filter((seed, i) => {
return seed !== value || i === target
})
}

if (nextList.length > 12) {
nextList.pop()
}

return nextList
}

This file was deleted.

Loading