Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale fix script #7580

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Add locale fix script #7580

merged 1 commit into from
Nov 29, 2019

Conversation

rekmarks
Copy link
Member

Now we can do yarn verify-locales:fix to run node ./development/verify-locale-strings.js --fix

@rickycodes rickycodes self-requested a review November 26, 2019 21:20
rickycodes
rickycodes approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@metamaskbot
Copy link
Collaborator

Builds ready [af04f5c]

Gudahtt
Gudahtt approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
As we discussed, this isn't really needed (yarn verify-locales --- fix works already) but it at least makes this flag more discoverable. Which is great, considering how tedious it can be to remove these messages manually.

@rickycodes rickycodes merged commit 5917da6 into develop Nov 29, 2019
Gudahtt pushed a commit that referenced this pull request Dec 3, 2019
@rekmarks @Gudahtt
add locale fix script (#7580)
c7f320b
Gudahtt added a commit that referenced this pull request Dec 3, 2019
@Gudahtt
Merge remote-tracking branch 'origin/develop' into master-sync
dfb63ee 
* origin/develop:
  Fix SimpleDropdown event bubbling (#7627)
  Remove unneeded store connections (#7625)
  Replace wild random number key with index (#7629)
  Use ES6 exports for selectors (#7626)
  Fix a typo made comparing previous prop (#7628)
  Connect distinct accounts per site (#7004)
  eslint: Enable more react/jsx-* rules (#7592)
  Enable react/no-unused-state rule for ESLint (#7609)
  Enable no-var rule for ESLint (#7590)
  Process URL fragment for ens-ipfs redirects (#7604)
  add locale fix script (#7580)
  Prevent redux state mutation (#7598)
@whymarrh whymarrh deleted the add-fix-locales-script branch January 15, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@rickycodes rickycodes rickycodes approved these changes

@danjm danjm Awaiting requested review from danjm

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rekmarks @metamaskbot @rickycodes @Gudahtt