process url fragment #7604
Merged
process url fragment #7604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use app.ens.domains instead of manager.ens.domains
whymarrh
approved these changes
Dec 2, 2019
Gudahtt
added a commit
that referenced
this pull request
Dec 3, 2019
* origin/develop: Fix SimpleDropdown event bubbling (#7627) Remove unneeded store connections (#7625) Replace wild random number key with index (#7629) Use ES6 exports for selectors (#7626) Fix a typo made comparing previous prop (#7628) Connect distinct accounts per site (#7004) eslint: Enable more react/jsx-* rules (#7592) Enable react/no-unused-state rule for ESLint (#7609) Enable no-var rule for ESLint (#7590) Process URL fragment for ens-ipfs redirects (#7604) add locale fix script (#7580) Prevent redux state mutation (#7598)
Gudahtt
pushed a commit
that referenced
this pull request
Dec 5, 2019
Also use app.ens.domains instead of manager.ens.domains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 - use app.ens.domains instead of manager.ens.domains
manager.ens.domains redirects to app.ens.domains however the pathname is stripped out breaking the feature to redirect to an unknown domain
this PR solves this issue
2 - process url fragment
ens url fragment are not processed and as such not resolved
this PR add the missing fragment.
I'm not familiar with swarm-ns, onion and zeronet however I added them the missing fragment.
This needs to be reviewed.
3 - The missing fragment happens also in Metamask Mobile on Android.
Thanks