Skip to content

Commit

Permalink
test: Remove Redundant Steps in WDIO to Fix Upgrade Test Failures (#1…
Browse files Browse the repository at this point in the history
…0835)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Cherry picked fix for upgrade test

Currently, both upgrading Appium test are failing on main. For
MultipleAccounts.feature, when the test relogin to the app after
upgrading to the app. This is happening because there is a step that
execute the Android Back button. We need to remove that step.

For ConnectedTestNetwork.feature, the test are failing because whats new
modal is not longer appearing after connected to the test network. We
need to remove that step.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e7dbc0b4-ebe0-49cb-aac6-3caf1a1f073b
<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
Andepande authored Aug 27, 2024
1 parent 2c3f777 commit 90b8853
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
3 changes: 0 additions & 3 deletions wdio/features/Upgrading/ConnectedTestNetwork.feature
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ Feature: Upgrade previous app build with current release
When I tap the Test Network toggle
And I tap on the "<Network>" button
Then "<Network>" should be displayed in network educational modal
And I close the Whats New modal
And I use the back button on Android
And I am on the wallet view
And I should see the added network name "<Network>" in the top navigation bar
And tokens <TOKEN> in account should be displayed
When I tap on the Settings tab option
Expand Down
1 change: 0 additions & 1 deletion wdio/features/Upgrading/MultipleAccounts.feature
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ Feature: Upgrade previous app build with current release while being connected t
And the splash animation completes
And I fill my password in the Login screen
And I log into my wallet
And I use the back button on Android
And I am on the wallet view
Then I am on the "<AccountName>" account
And I tap on the Settings tab option
Expand Down

0 comments on commit 90b8853

Please sign in to comment.