Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Remove Redundant Steps in WDIO to Fix Upgrade Test Failures #10835

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

Andepande
Copy link
Member

@Andepande Andepande commented Aug 27, 2024

Description

Cherry picked fix for upgrade test

Currently, both upgrading Appium test are failing on main. For MultipleAccounts.feature, when the test relogin to the app after upgrading to the app. This is happening because there is a step that execute the Android Back button. We need to remove that step.

For ConnectedTestNetwork.feature, the test are failing because whats new modal is not longer appearing after connected to the test network. We need to remove that step.

Screenshots/Recordings

Before

After

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e7dbc0b4-ebe0-49cb-aac6-3caf1a1f073b

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Remove failing steps in connectedTestNetwork feature file
Remove failing step in MultipleAccounts.feature for upgrade test
@Andepande Andepande added the No QA Needed Apply this label when your PR does not need any QA effort. label Aug 27, 2024
@Andepande Andepande requested a review from a team as a code owner August 27, 2024 12:38
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 27, 2024
@Andepande Andepande changed the title Test/fix upgrade tests Test: Remove Redundant Steps in WDIO to Fix Upgrade Test Failures Aug 27, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 27, 2024
Copy link
Contributor

github-actions bot commented Aug 27, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 247a53b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/170e270f-0738-4ae8-9461-a78a082383fe

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sethkfman sethkfman merged commit 90b8853 into release/7.30.0 Aug 27, 2024
41 of 43 checks passed
@sethkfman sethkfman deleted the test/fix-upgrade-tests branch August 27, 2024 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants