Skip to content

Commit

Permalink
refactor: Update @metamask/assets-controllers patch
Browse files Browse the repository at this point in the history
The `@metamask/assets-controllers` patch added as part of the
permission system implementation [1] has been updated to more closely
match how the feature was implemented upstream [2]. It should be
functionally equivalent.

This relates to MetaMask/mobile-planning#877

[1]: #5062
[2]: MetaMask/core#1124
  • Loading branch information
Gudahtt committed Jul 26, 2023
1 parent a936db3 commit e4225ac
Show file tree
Hide file tree
Showing 8 changed files with 128 additions and 129 deletions.
2 changes: 1 addition & 1 deletion app/components/UI/AddCustomToken/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export default class AddCustomToken extends PureComponent {
if (!(await this.validateCustomToken())) return;
const { TokensController } = Engine.context;
const { address, symbol, decimals, name } = this.state;
await TokensController.addToken(address, symbol, decimals, null, name);
await TokensController.addToken(address, symbol, decimals, { name });

AnalyticsV2.trackEvent(
MetaMetricsEvents.TOKEN_ADDED,
Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/Ramp/hooks/useHandleSuccessfulOrder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ function useHandleSuccessfulOrder() {
toLowerCaseEquals(t.address, address),
)
) {
await TokensController.addToken(address, symbol, decimals, null, name);
await TokensController.addToken(address, symbol, decimals, { name });
}
},
[selectedChainId],
Expand Down
5 changes: 4 additions & 1 deletion app/components/UI/SearchTokenAutocomplete/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ const SearchTokenAutocomplete = ({ navigation }: Props) => {

const addToken = useCallback(async () => {
const { TokensController } = Engine.context as any;
await TokensController.addToken(address, symbol, decimals, iconUrl, name);
await TokensController.addToken(address, symbol, decimals, {
image: iconUrl,
name,
});

AnalyticsV2.trackEvent(MetaMetricsEvents.TOKEN_ADDED, getAnalyticsParams());

Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/Swaps/QuotesView.js
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ async function addTokenToAssetsController(newToken) {
)
) {
const { address, symbol, decimals, name } = newToken;
await TokensController.addToken(address, symbol, decimals, null, name);
await TokensController.addToken(address, symbol, decimals, { name });
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/components/UI/Swaps/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ function SwapsAmountView({
) {
const { TokensController } = Engine.context;
const { address, symbol, decimals, name } = sourceToken;
await TokensController.addToken(address, symbol, decimals, null, name);
await TokensController.addToken(address, symbol, decimals, { name });
}
return navigation.navigate(
'SwapsQuotesView',
Expand Down
5 changes: 4 additions & 1 deletion app/components/Views/SendFlow/Confirm/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,10 @@ class Confirm extends PureComponent {
const { TokensController } = Engine.context;

if (!contractBalances[address]) {
await TokensController.addToken(address, symbol, decimals, image, name);
await TokensController.addToken(address, symbol, decimals, {
image,
name,
});
}

const [, , rawAmount] = decodeTransferData('transfer', data);
Expand Down
7 changes: 2 additions & 5 deletions app/components/hooks/useAddressBalance/useAddressBalance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,10 @@ const useAddressBalance = (asset: Asset, address?: string) => {
return;
}
if (!contractBalances[contractAddress]) {
TokensController.addToken(
contractAddress,
symbol,
decimals,
TokensController.addToken(contractAddress, symbol, decimals, {
image,
name,
);
});
}
}
// eslint-disable-next-line react-hooks/exhaustive-deps
Expand Down
232 changes: 114 additions & 118 deletions patches/@metamask+assets-controllers+5.0.0.patch

Large diffs are not rendered by default.

0 comments on commit e4225ac

Please sign in to comment.