[PS] Implement Permission System #5062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
force-pushed
the
feature/4754-permission-system
branch
3 times, most recently
from
6657b46
to
9968d31
Compare
* Fix image styling * Update constant name * Replace wallet navbar with PickerNetwork
* Create AccountSelectionList * Create temp loader component * Create temp sheet actions component * Fix AvatarGroup positioning * Provide reserved overlay spacing for bottom sheet * Fix sheet header typo * Make analytics params optional * Rename AccountSelectorList * Create new account selector * Add AccountSelector to navigation stack * Replace all account selection logic * Improve caching logic for ENS name fetch. Introduce 1 hour cache to optimize for network calls. Fetching from middle out beginning with selected account. * Add lodash debounce to prevent taps in quick succession on bottom sheet * Throw away any debounce innvocation when bottom sheet is unmounted * Introduce loading to account selector. Readd test IDS * Remove old account list * Clean up useAccounts * Update snapshots * Fix logic after pulling from main * Update snapshots
* Add new logos * Update styles. Add missing exports.
* Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values
* Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values * Organize account hooks and utils * Export ENS cache. Update account util to return ENS name. * Update account selector * Remove account selector styles
* Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values * Organize account hooks and utils * Export ENS cache. Update account util to return ENS name. * Update account selector * Remove account selector styles * Hook up permission system controller logic
* Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values * Organize account hooks and utils * Export ENS cache. Update account util to return ENS name. * Update account selector * Remove account selector styles * Hook up permission system controller logic * Connect PS to browser. Pass from address to transactions.
* Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values * Organize account hooks and utils * Export ENS cache. Update account util to return ENS name. * Update account selector * Remove account selector styles * Hook up permission system controller logic * Connect PS to browser. Pass from address to transactions. * Create first time connect sheet
* Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values * Organize account hooks and utils * Export ENS cache. Update account util to return ENS name. * Update account selector * Remove account selector styles * Hook up permission system controller logic * Connect PS to browser. Pass from address to transactions. * Create first time connect sheet * Create permissions sheet
* Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values * Organize account hooks and utils * Export ENS cache. Update account util to return ENS name. * Update account selector * Remove account selector styles * Hook up permission system controller logic * Connect PS to browser. Pass from address to transactions. * Create first time connect sheet * Create permissions sheet * Add translations to permission system * (BottomTabBar): implement new BottomTabBar * (ActivityView): move nav stack to wallet * (Transactions): update navigation header * (ActivityView): fix back button onPress * (ActivityView): fix getNavbarOptions args * (BrowserBottomBar): remove bottomPadding * (Transactions): fix empty screen height * (Transactions): setup main modal stack navigator Co-authored-by: Cal Leung <cleun007@gmail.com>
* Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values * Organize account hooks and utils * Export ENS cache. Update account util to return ENS name. * Update account selector * Remove account selector styles * Hook up permission system controller logic * Connect PS to browser. Pass from address to transactions. * Create first time connect sheet * Create permissions sheet * Add translations to permission system * (BottomTabBar): implement new BottomTabBar * (ActivityView): move nav stack to wallet * (Transactions): update navigation header * (ActivityView): fix back button onPress * (ActivityView): fix getNavbarOptions args * (BrowserBottomBar): remove bottomPadding * (Transactions): fix empty screen height * (Transactions): setup main modal stack navigator * (BrowserNav): implement new PS browser navbar * (Navbar): fix AccountRightButton onPress event Co-authored-by: Cal Leung <cleun007@gmail.com>
* Feature/4768 action selector sheet (#4891) * Create AccountSelectionList * Create temp loader component * Create temp sheet actions component * Fix AvatarGroup positioning * Provide reserved overlay spacing for bottom sheet * Fix sheet header typo * Make analytics params optional * Rename AccountSelectorList * Create new account selector * Add AccountSelector to navigation stack * Replace all account selection logic * Improve caching logic for ENS name fetch. Introduce 1 hour cache to optimize for network calls. Fetching from middle out beginning with selected account. * Add lodash debounce to prevent taps in quick succession on bottom sheet * Throw away any debounce innvocation when bottom sheet is unmounted * Introduce loading to account selector. Readd test IDS * Remove old account list * Clean up useAccounts * Update snapshots * Fix logic after pulling from main * Update snapshots * [PS] Connect ps to browser (#5051) * Add new logos * Update styles. Add missing exports. * Patch controllers. Introduce react-native-get-random-values * Organize account hooks and utils * Export ENS cache. Update account util to return ENS name. * Update account selector * Remove account selector styles * Hook up permission system controller logic * Connect PS to browser. Pass from address to transactions. * Update toast copy * Fix misc * Hide invalid fiat balance * Comment permission util for clarity * Move account type out of Toast * Update imports * Replace account depedency in browser tab * Update styles * Prevent auto account selection on account creation * Remove spacing from toast translation strings * Update browser icon * Remove all permissions when deleting wallet * Fix AvatarNetwork showfallback * Open separate browser from warning * Remove unnecessary padding on browser * Show account switch toast when switching between tabs * Fix unrecognized network logos * Update snapshots * Pull full screen modal/sheets to Root modal flow in nav stack * Fix browser tab test * Fix test * Fix NetworkList test * Remove redundant useAccounts
* (Navigation): update route names * (BrowserUrlBar): use getURLProtocol to check SSL * (BrowserUrlBar): test margins * (Browser): fix Android url bar onPress
Cal-L
force-pushed
the
feature/4754-permission-system
branch
from
9968d31
to
0d8c597
Compare
…etaMask/metamask-mobile into feature/4754-permission-system
* fix network casing name in educational network info modal * fix no network avatar for frequent networks
* updated browser tests to run on thje permission system * Returning values to original state * Solve account approval modal issues and option menu test issues * Update network text value * updating failing tests * Merge latest changes an returning config values to default * Update * Add AddContact.js file * update AddContact page object + fix linting issue --------- Co-authored-by: Curtis <Curtis.David7@gmail.com>
* [IMPROVEMENT] Refactor ProtectYourWallet section in the security section (#5600) * [FIX] Analytics event interface (#5613) * Fix analytics events * Bump version and build numbers * Revert "Bump version and build numbers" This reverts commit 247789b. * Handle ENS Address Error (#5605) * resolving ens address * lint * cleaner name * Bump versions to make prod build for testing * Revert "Bump versions to make prod build for testing" This reverts commit 43d0dad. Co-authored-by: Plasma Corral <32695229+plasmacorral@users.noreply.github.com> * [FIX] Make Prettier work in wdio directory (#5612) * make Prettier work in wdio directory - remove wdio from the Prettier exclude file - add Gherkin Prettier pluggin for .feature - update `yarn format` script to take .feature files into account - first pass of js and feature files formating in wdio dir using `yarn format` * format after branch update from main * extract eslint config to deal with it in another PR - create an eslint ignore file and use it as default instead of prettier ignore with eslint (on both scripts, lint and fix) - add the wdio dir back in .eslintignore to deal with it in another eslint only PR - remove useless ignore lines as already ignored by the android line * [FIX] SRP Quiz content and translations (#5626) * [IMPROVEMENT] Refactor Personal Signature (#5551) * personal signature refactor * Fix currency display (#5623) * [FEAT] Add friction to SRP reveal (#5579) * Add base modals * Add navigation for dev purposes * Update Main Nav * Update navigation * Add new Route * Update quiz files * Update modals * Add QuizStage enum * Add interfaces * Update styles * Update quiz components * Update IQuizInformationProps interface * Rename files * Add quiz flow * Revert AccountView changes * Add Quiz to security settings * Update title interface and style * Update QuizContent * Update styles * Update dep arrays * Add quiz structure * Move QuizStage to type file * Update QuizContent component * Add method to dismiss modal * Revert Podfile.lock * Fix typo * Remove unnecessary comments * Fix structure error * Add analytic events * Fix small content issues * Add image to quiz intro * Add image to quiz intro * Add link to zendesk article * Remove quiz structure cobject * Bump version and build number * Ignore advisories * Revert "Bump version and build number" This reverts commit b9833bb. * Revert "Ignore advisories" This reverts commit 17d68eb. * Remove message * Update dependencies array * Use Routes for RevealPrivateCredentialView * Remove unused interfaces * Move SRP guide method to QuizModal * Update dependency array * Refactor switch-case statement * Fix nav bug * Dismiss Quiz if the app goes to the background * E2e appium folder structure change (#5632) * Re-arranged wdio file structure Re-arranged wdio file structure & refactor imports * Added missing Address Input ID * Commented out failing test * Removed ignored test * rename folder to "Accounts" * move lockResetPassword out of onboarding folder --------- Co-authored-by: Curtis <Curtis.David7@gmail.com> * fix import path * fix e2e after merging main. * fix linting * Remove unused files. Fix personal sign --------- Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com> Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com> Co-authored-by: Plasma Corral <32695229+plasmacorral@users.noreply.github.com> Co-authored-by: Nicolas MASSART <NicolasMassart@users.noreply.github.com> Co-authored-by: Cal Leung <cleun007@gmail.com> Co-authored-by: yande <110056475+Andepande@users.noreply.github.com>
* Change ImportPrivateKey to TS file * Add QR scanner screen to import stack * Change ts to tsx * Refactor import private key * Don't show alert when importing account from account selector * Fix deleting last imported account when in connected flow * Fix dismissing keyboard when selecting top right nav button on webview * Fix contrast for private key QR code * Disable Permission System for WalletConnect and MMSDK * Fix undefined origin issue * fix browser title bar misalignment * fix networkinfo avatar letter * Resolve PR comments --------- Co-authored-by: João Loureiro <joao.loureiro@consensys.net>
* place analytics events * rename permission connect request events add source property * update analytics * fix import * safeguarding when there are no active tabs * rename event properties * update source field * update request completed properties * fix networklist test
Cal-L
added
release-6.0.0
cortisiko
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
This feature is QA passed 🌮 🌮 . The e2e tests were updated to reflect changes in this feature. they all passed. See iOS test run and android test run.
Test coverage:
- See my feature file with most of my test scenarios for this feature.
- Removing networks while connected to a dapp and ensuring the network defaults back to mainnet. I also ensured transactions were successful after network removal.
- dapp and regular transactions (send, swap, approve tokens, deploy contracts, mint nfts)
cortisiko
added
QA Passed
owencraston
reviewed
Feb 2, 2023
owencraston
reviewed
Feb 2, 2023
owencraston
reviewed
Feb 2, 2023
owencraston
reviewed
Feb 2, 2023
owencraston
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Reviewed latest changes with @Cal-L and it all looks good to me. Just left a few comments for future improvements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Implements Permission System, an account access management system.
High level touch points
UI Changes
Test Cases
https://www.notion.so/Test-Cases-6c6726b6ff9e4c40b829ee0140b7997a
Bug Report
https://github.com/MetaMask/mobile-planning/issues/528
Screenshots/Recordings
Issue
Check #4754 for test cases, designs, knowledge shares & bug reports
Checklist