-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update @metamask/controller-utils
to v3.4
#6884
Conversation
@metamask/controller-utils
to v3.4@metamask/controller-utils
to v3.4
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
The parser package has been evaluated by us already, and the lack of a README in general isn't a big concern for us. The flagged module in |
17ded93
to
a0351e7
Compare
The `@metamask/controller-utils` package has been updated to v3.4. This package had previously been held back because v3.1.0 introduced a usage of the BigInt API, which was a compatibility issue. But that should no longer be a problem now that React Native has been upgraded. There were no breaking changes in this range of updates, but there were a few additions and rearrangements that required substantial patch updates. This change was done to simplify PR #6872, which is part of MetaMask/mobile-planning#798
a0351e7
to
34e05ab
Compare
For reference, here is the source for v3.4.0: https://github.com/MetaMask/core/blob/%40metamask/controller-utils%403.4.0/packages/controller-utils/src/constants.ts The networks Linea Goerli and Linea Mainnet weren't added until a later version, here: MetaMask/core#1423 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Kudos, SonarCloud Quality Gate passed! |
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
The
@metamask/controller-utils
package has been updated to v3.4. This package had previously been held back because v3.1.0 introduced a usage of the BigInt API, which was a compatibility issue. But that should no longer be a problem now that React Native has been upgraded.There were no breaking changes in this range of updates, but there were a few additions and rearrangements that required substantial patch updates.
Issue
This change was done to simplify PR #6872, which is part of https://github.com/MetaMask/mobile-planning/issues/798
Checklist