Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove splash animation wait step from Cold Start Launch time test script #6931

Merged
merged 3 commits into from
Jul 28, 2023
Merged

fix: Remove splash animation wait step from Cold Start Launch time test script #6931

merged 3 commits into from
Jul 28, 2023

Conversation

SamuelSalas
Copy link
Member

Description
When running the ColdStartLaunchTimes.feature on bitrise, the splash animation was to fast for appium and created some inconsistencies. So it has been removed and just to assert that the Welcome Screen is displayed.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@SamuelSalas SamuelSalas requested a review from a team as a code owner July 28, 2023 22:58
cortisiko
cortisiko approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cortisiko cortisiko merged commit 65bc18f into main Jul 28, 2023
12 checks passed
@cortisiko cortisiko deleted the fix/update-cold-start-animation-assert branch July 28, 2023 23:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@chrisleewilcox chrisleewilcox Awaiting requested review from chrisleewilcox

@Andepande Andepande Awaiting requested review from Andepande

Assignees
No one assigned
Labels
release-7.6.0 Issue or pull request that will be included in release 7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelSalas @cortisiko @metamaskbot