Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove splash animation wait step from Cold Start Launch time test script #6931

Merged
merged 3 commits into from
Jul 28, 2023
Merged

fix: Remove splash animation wait step from Cold Start Launch time test script #6931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31f9898
Change wait for splash animation to expect to displayed assertion
SamuelSalas Jul 28, 2023
2d7730c
Remove splash animation steps
SamuelSalas Jul 28, 2023
d4439cc
Merge branch 'main' into fix/update-cold-start-animation-assert
SamuelSalas Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions wdio/features/Performance/ColdStartLaunchTimes.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@androidApp
@androidApp
@performance
Feature: App Cold Start Launch Times
This feature measures the cold start of the app when:
Expand All @@ -7,7 +7,7 @@ Feature: App Cold Start Launch Times

Scenario: Measure cold start launch time on fresh install
Given the app is launched
When the app displayed the splash animation
When the Welcome screen is displayed
Then the app should launch within "4" seconds

Scenario: Measure cold start launch time after importing a wallet
Expand All @@ -19,8 +19,6 @@ Feature: App Cold Start Launch Times
When I kill the app
And I relaunch the app
And the timer starts running
And the app displayed the splash animation
And the splash animation disappears
And I fill my password in the Login screen
And I log into my wallet
Then the app should launch within "14" seconds
6 changes: 5 additions & 1 deletion wdio/screen-objects/Onboarding/OnboardingCarousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class WelcomeScreen {
}

get title() {
return Selectors.getElementBgetXpathElementByResourceIdyPlatform(
return Selectors.getXpathElementByResourceId(
WALLET_SETUP_SCREEN_TITLE_ID,
);
}
Expand All @@ -50,6 +50,10 @@ class WelcomeScreen {
}
}

async isScreenDisplayed() {
expect(this.screen).toBeDisplayed();
}

async waitForSplashAnimationToNotExit() {
const elem = await this.splashScreenMetamaskAnimationId;
await elem.waitForExist({ reverse: true });
Expand Down
6 changes: 3 additions & 3 deletions wdio/step-definitions/common-steps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ import LoginScreen from '../screen-objects/LoginScreen';
import TermOfUseScreen from '../screen-objects/Modals/TermOfUseScreen';
import WhatsNewModal from '../screen-objects/Modals/WhatsNewModal';

Then(/^the Welcome Screen is displayed$/, async () => {
await WelcomeScreen.waitForScreenToDisplay();
Then(/^the Welcome screen is displayed$/, async () => {
await WelcomeScreen.isScreenDisplayed();
});

Given(/^the app displayed the splash animation$/, async () => {
await WelcomeScreen.waitForSplashAnimationToDisplay();
await WelcomeScreen.isScreenDisplayed();
});

Given(/^the splash animation disappears$/, async () => {
Expand Down
Loading