-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch handling of missing token price #8421
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8421 +/- ##
=======================================
Coverage 40.42% 40.42%
=======================================
Files 1239 1239
Lines 29976 29976
Branches 2869 2869
=======================================
Hits 12117 12117
Misses 17168 17168
Partials 691 691 ☔ View full report in Codecov by Sentry. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/90b46fd5-c6ed-4f84-a048-b265023f8612 |
Description
Patches MetaMask/core#3687
Fixes issue where importing 1 un-pricable token causes all tokens to lose prices.
Related issues
Fixes:
Manual testing steps
0xc7ad37edae28d8cd04bbe4a6ecf072314faed1be
)Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist