Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Engine does not exist #9971

Closed
wants to merge 1 commit into from

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Jun 13, 2024

Description

  • Added a patch that replaces throw an error when the selectedNetworkClientId is not defined, returns the state data that other controllers need
  • Added a capture exception so we know the state of the network controller if no selectedNetworkClientId is defined

Related issues

Fixes #9958

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…entId is not defined, returns the state data that other controllers need, also added a capture exception for we know the state of network controller if no selectedNetworkClientId is defined
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Jun 13, 2024
@tommasini tommasini requested review from a team as code owners June 13, 2024 11:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jun 13, 2024

@tommasini tommasini closed this Jun 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant