Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sentry] Error: Engine does not exist #9958

Closed
sentry-io bot opened this issue Jun 12, 2024 · 3 comments · Fixed by #9978
Closed

[Sentry] Error: Engine does not exist #9958

sentry-io bot opened this issue Jun 12, 2024 · 3 comments · Fixed by #9978
Assignees
@tommasini
Labels
area-Sentry Issue from Sentry regression-prod-7.24.0 Regression bug that was found in production in release 7.24.0 release-7.24.3 Issue or pull request that will be included in release 7.24.3 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-mobile-platform type-bug Something isn't working

Comments

@sentry-io
Copy link

sentry-io bot commented Jun 12, 2024 •
edited by sethkfman
Loading

Incident initially reported by CS with

Sentry Issue: METAMASK-MOBILE-2G4N
img_8281_720

User updates their MetaMask app to version 7.24.0 when they open their wallet. The error appears.

Error: Engine does not exist


  at r (ses.cjs:7676:17)
  at assertEngineExists (app/core/Engine.ts:1389:15)
  at default.get__context (app/core/Engine.ts:1397:5)
  at AuthenticationService#lockApp (app/core/Authentication/Authentication.ts:444:40)
  at appTriggeredAuth (app/components/Nav/App/index.js:334:30)
...
(20 additional frame(s) were not displayed)
@sethkfman sethkfman added type-bug Something isn't working team-mobile-platform regression-prod-* Regression bug that was found in production in release * regression-prod-7.24.0 Regression bug that was found in production in release 7.24.0 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing and removed regression-prod-* Regression bug that was found in production in release * labels Jun 12, 2024
@metamaskbot metamaskbot changed the title Error: Engine does not exist [Sentry] Error: Engine does not exist Jun 13, 2024
@metamaskbot metamaskbot added the area-Sentry Issue from Sentry label Jun 13, 2024
@sentry-io Sentry.io
Copy link
Author

sentry-io bot commented Jun 13, 2024

Sentry Issue: METAMASK-MOBILE-2G4P

@NicolasMassart NicolasMassart mentioned this issue Jun 13, 2024
Closed
7 tasks
@sentry-io Sentry.io
Copy link
Author

sentry-io bot commented Jun 13, 2024

Sentry Issue: METAMASK-MOBILE-2G4K

@tommasini tommasini mentioned this issue Jun 13, 2024
Merged
7 tasks
@gauthierpetetin gauthierpetetin linked a pull request Jun 13, 2024 that will close this issue
fix: Engine does not exist, network controller is missing ids #9978
Merged
7 tasks
tommasini added a commit that referenced this issue Jun 13, 2024
@tommasini
fix: Engine does not exist, network controller is missing ids (#9978)
44f03bd 
## **Description**
Added migration that populates the missing ids on network controller
state

## **Related issues**

Fixes: #9973
#9958

## **Manual testing steps**

1. Go to version 7.5.0
2. Add a custom network via popular list
3. Update to this PR
4. Shouldn't have the Engine does not exist issue

## **Screenshots/Recordings**


### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.24.3 Issue or pull request that will be included in release 7.24.3 label Jun 19, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.24.3 on issue. Adding release label release-7.24.3 on issue, as issue is linked to PR #9978 which has this release label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommasini tommasini

Labels
area-Sentry Issue from Sentry regression-prod-7.24.0 Regression bug that was found in production in release 7.24.0 release-7.24.3 Issue or pull request that will be included in release 7.24.3 Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-mobile-platform type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Engine does not exist, network controller is missing ids MetaMask/metamask-mobile
4 participants
@NicolasMassart @sethkfman @metamaskbot @tommasini