fix: Engine does not exist, network controller is missing ids #9978

tommasini · 2024-06-13T14:02:35Z

Description

Added migration that populates the missing ids on network controller state

Related issues

Fixes: #9973
#9958

Manual testing steps

Go to version 7.5.0
Add a custom network via popular list
Update to this PR
Shouldn't have the Engine does not exist issue

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…state

github-actions · 2024-06-13T14:02:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…lient id value and also to prioritize selected network client id be provider config id first instead of the key of a matching rpc url on networkConfigurations object

app/store/migrations/043.ts

app/store/migrations/043.test.ts

app/store/migrations/043.ts

…ning it, updated TSDoc on the migration, also added test cases for every scenario and more one that triggers when the rpc url matches on network configuration object and do not have id on provider config

Gudahtt

LGTM!

sonarcloud · 2024-06-13T16:43:00Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
98.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-06-19T20:08:42Z

No release label on PR. Adding release label release-7.24.3 on PR, as PR was added to branch 7.24.3 when release was cut.

added migration that populates the missing ids on network controller …

4b26185

…state

tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Jun 13, 2024

tommasini requested a review from a team as a code owner June 13, 2024 14:02

modify migration to include fallback to mainet for selected network c…

a33f05a

…lient id value and also to prioritize selected network client id be provider config id first instead of the key of a matching rpc url on networkConfigurations object