Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT contract interactions #181

Merged
merged 2 commits into from
Jul 12, 2022
Merged

NFT contract interactions #181

merged 2 commits into from
Jul 12, 2022

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Jul 12, 2022 •
edited
Loading

Add the following methods:

  • approve (sets the approval for an address to transfer a single NFT)
  • setApprovalForAll (sets the approval for an address to transfer all NFTs)
  • transferFrom (transfer a single NFT from one account to another)

approve
test-dapp approve

setApprovalForAll
test-dapp setApprovalForAll

transferFrom
test-dapp transferFrom

@PeterYinusa PeterYinusa marked this pull request as ready for review July 12, 2022 15:26
@PeterYinusa PeterYinusa requested a review from a team as a code owner July 12, 2022 15:26
adonesky1
adonesky1 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Peter! Glad we're going to have E2E tests for these flows at last!

@PeterYinusa PeterYinusa merged commit 07c2ec0 into main Jul 12, 2022
@PeterYinusa PeterYinusa deleted the nft-contract-interactions branch July 12, 2022 17:11
@brad-decker brad-decker mentioned this pull request Jul 27, 2022
Merged
@PeterYinusa PeterYinusa mentioned this pull request Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterYinusa @adonesky1