Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add collectibles contract #205

Merged
merged 3 commits into from
Feb 6, 2023
Merged

add collectibles contract #205

merged 3 commits into from
Feb 6, 2023

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Jan 25, 2023 •
edited
Loading

@PeterYinusa PeterYinusa requested a review from a team as a code owner January 25, 2023 12:23
@seaona
Copy link
Contributor

seaona commented Feb 3, 2023

I've tried verifying the TDC contract with this source code but I'm getting an error.
Is it exactly the same contract code? Another possibility is that I'm doing something wrong here.
I've tried both using Etherscan manually and with the Remix plugin (which does not go so well sometimes), but didn't succeed on any.

verifying-tdc-failed.mp4

@PeterYinusa
Copy link
Contributor Author

PeterYinusa commented Feb 3, 2023 •
edited
Loading

Before:

verify collectibles contract failed

After:

I pinned the open zeppelin contracts to the specific version used to create the collectables contract last year. See: ee18ca0

I also compiled with version 0.8.10

verify collectibles contract

The contract can now be verified. See: verified TestDappCollectibles contract

@PeterYinusa PeterYinusa merged commit 4544f03 into main Feb 6, 2023
@PeterYinusa PeterYinusa deleted the collectibles-contract branch February 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpuri jpuri jpuri approved these changes

@seaona seaona seaona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterYinusa @seaona @jpuri