Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revoke NFT allowances #187

Merged
merged 1 commit into from
Aug 15, 2022
Merged

revoke NFT allowances #187

merged 1 commit into from
Aug 15, 2022

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Aug 12, 2022 •
edited
Loading

Add the following methods:

  • setApprovalForAll (unsets the approval for an address, preventing the transfer of all NFTs)

Test-Dapp

Revoke

@PeterYinusa PeterYinusa marked this pull request as ready for review August 12, 2022 12:12
@PeterYinusa PeterYinusa requested a review from a team as a code owner August 12, 2022 12:12
adonesky1
adonesky1 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PeterYinusa PeterYinusa merged commit e9b4df8 into main Aug 15, 2022
@PeterYinusa PeterYinusa deleted the revoke branch August 15, 2022 10:50
@PeterYinusa PeterYinusa mentioned this pull request Sep 21, 2022
Merged
@PeterYinusa PeterYinusa mentioned this pull request Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkwing darkwing darkwing approved these changes

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterYinusa @darkwing @adonesky1