Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

deps: Bump ethereumjs and metamask packages #453

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

legobeat
Copy link
Contributor

No description provided.

@socket-security
Copy link

socket-security bot commented Oct 13, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/safe-event-emitter@3.0.0, eth-block-tracker@8.1.0, bech32@1.1.4, @metamask/eth-json-rpc-middleware@12.0.0, ethers@5.7.2, mcl-wasm@0.7.9, @ethereumjs/rlp@4.0.1, rlp@2.2.6, rlp@2.2.7

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @ethereumjs/rlp@4.0.1
@SocketSecurity ignore rlp@2.2.6
@SocketSecurity ignore rlp@2.2.7

bin script confusion ok (nb: the rlp@2.2.6 duplication is not actually present)

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @metamask/safe-event-emitter@3.0.0
@SocketSecurity ignore eth-block-tracker@8.1.0
@SocketSecurity ignore bech32@1.1.4

new author ok

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @metamask/eth-json-rpc-middleware@12.0.0
@SocketSecurity ignore ethers@5.7.2
@SocketSecurity ignore mcl-wasm@0.7.9

network access ok

@legobeat legobeat marked this pull request as ready for review October 13, 2023 04:48
@legobeat legobeat requested a review from a team as a code owner October 13, 2023 04:48
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 13, 2023
var vm = self.vm = createVm(self.engine, blockNumber, {
enableHomestead: true
const vm = self.vm = new VM({
stateManager: new EthersStateManager({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@legobeat legobeat merged commit 7e28f6d into MetaMask:main Oct 18, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants